This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Let HNC propagate builtin admin rolebindings #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I _think_ HNC used to be able to propagate the `admin` role, but there were several permission (deletecollection, impersonate) that don't appear to be working in 1.15. I've now added these permissions to the HNC service account so it can grant them. Tested: new hack/test-issue-772.sh verifies that HNC can propagate the `admin` builtin; it fails without this change and passes with it. The existing hack/test-issue-771.sh, which uses `cluster-admin`, continues to be unpropagateable as expected.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, yiqigao217 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think HNC used to be able to propagate the
adminrole, but therewere several permission (deletecollection, impersonate) that don't
appear to be working in 1.15. I've now added these permissions to the
HNC service account so it can grant them.
Tested: new hack/test-issue-772.sh verifies that HNC can propagate the
adminbuiltin; it fails without this change and passes with it. Theexisting hack/test-issue-771.sh, which uses
cluster-admin, continuesto be unpropagateable as expected.
Fixes #772
/assign @yiqigao217