Skip to content
This repository has been archived by the owner on Jan 17, 2020. It is now read-only.

Add script to run tests on prow #45

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

hoegaarden
Copy link
Contributor

To address issue #16. This adds a script to run tests on Prow.

A PR to https://github.com/kubernetes/test-infra will follow to add the Prow job, which will call this script.

@hoegaarden hoegaarden requested a review from a team February 20, 2018 15:06
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 20, 2018
@hoegaarden
Copy link
Contributor Author

/test pull-frameworks-test

2 similar comments
@jamesjoshuahill
Copy link
Contributor

/test pull-frameworks-test

@hoegaarden
Copy link
Contributor Author

/test pull-frameworks-test

@BenTheElder
Copy link

/test pull-frameworks-test

@BenTheElder
Copy link

@BenTheElder
Copy link

seeing some weird failures in bootstrap @krzyzacy https://pastebin.com/xeygKqFC

@BenTheElder
Copy link

/test pull-frameworks-test

@hoegaarden
Copy link
Contributor Author

       [...]
07 | I0226 19:14:22.839] Checkout: /go/src/k8s.io/frameworks master:d99c401ff4161602f4a158757552b2fe183d1501,45:8c458a464b68bdae239348e2ee04c966af836454 to /go/src/k8s.io/frameworks
       [...]
19 | I0226 19:14:22.860] Call:  git fetch --quiet --tags https://github.com/kubernetes/frameworks master +refs/pull/45/head:refs/pr/45
20 | W0226 19:14:23.091] fatal: could not read Username for 'https://github.com': No such device or address
       [...]
  1. This repo does not (yet?) have a k8s.io vanity URL, so I guess that repo would be cloned into the wrong path (line 07)
  2. This repo is not in the kubernetes org, but in kubernetes-sig-testing (line 19)
  3. I am not sure if the error could not read Username for ... is an artefact from the above problem, or if there is actually a problem with credentials. I guess, if we'd be in the kubernetes org, that'd just work fine.

I will try to find out if the path to clone into and the org to clone from are configurable.

Thanks for the logs @BenTheElder -- helps a lot!

hoegaarden added a commit to hoegaarden/test-infra that referenced this pull request Feb 27, 2018
kubernetes-sig-testing/frameworks / pull-frameworks-test

kubernetes-retired/testing_frameworks#45 (comment)
@krzyzacy
Copy link

ahh... I should've noticed the org difference :-)

@hoegaarden
Copy link
Contributor Author

Well, me too.

@hoegaarden
Copy link
Contributor Author

/test pull-frameworks-test

@BenTheElder
Copy link

@hoegaarden
Copy link
Contributor Author

@kubernetes-sig-testing/reviewers @kubernetes-sig-testing/owners is anyone able to give this PR a quick look? I slowly want to move to prow (as a first step probably have prow and travis run in parallel) and this is a prerequisite to do so.

Copy link

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: changing LGTM is restricted to assignees, and only kubernetes-sig-testing org members may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, hoegaarden, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hoegaarden,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2105dfc into kubernetes-retired:master Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants