-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk: add tags to ECS snapshot #905
disk: add tags to ECS snapshot #905
Conversation
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@shusaan How do you like this design? |
620ee91
to
13fadfc
Compare
it is good just for confirm it will support multiple custom tags, like
|
@shusaan with current design, this is written as:
|
This one is good but one suggestion, i think if you apply this pattern |
Yes, I'm aware of the If this look OK to @mowangdk , I will also implement this on StorageClass. |
There are many paramters. Avoid modify every call site if we have even more.
Split it into paramter and annotation part. Better error reporting. And prepare for custom tags feature.
Automatically add 3 more tags to every ECS snapshot: - ack.aliyun.com: current ACK cluster ID - csi.alibabacloud.com/snapshot/name - csi.alibabacloud.com/snapshot/namespace Also allow users to add custom tags. User should specify "snapshotTags/tagKey: tagValue" in VolumeSnapshotClass to add tag "tagKey: tagValue". This design allows arbitrary keys and values. Compared with the design of disk tags, which does not allow "," in key or value, or ":" in key. If this design works fine, we can also implement this on disk tags.
13fadfc
to
d3b6fd0
Compare
@mowangdk any ETA for this please? |
@mowangdk any update please |
we have got a large pr ready to merge , this pr will merged after that. and it may have an impact on the existing logic, and we'll probably merge it around January of next year. |
@mowangdk any update please |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @mowangdk can you please share expected release of this. |
What type of PR is this?
/kind feature
/kind design
What this PR does / why we need it:
Automatically add 3 more tags to every ECS snapshot:
Also allow users to add custom tags.
User should specify "snapshotTags/tagKey: tagValue" in VolumeSnapshotClass to add tag "tagKey: tagValue". This design allows arbitrary keys and values, compared with the design of disk tags, which does not allow "," in key or value, or ":" in key.
If this design works fine, we can also implement this on disk tags.
Which issue(s) this PR fixes:
Fixes #900
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: