Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disk: add tags to ECS snapshot #905

Merged
merged 3 commits into from
Jan 31, 2024
Merged

disk: add tags to ECS snapshot #905

merged 3 commits into from
Jan 31, 2024

Commits on Oct 28, 2023

  1. disk: refactor: use struct for snapshot parameters 

    There are many paramters. Avoid modify every call site if we have even more.
    @huww98
    huww98 committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    bff25c9 View commit details
    Browse the repository at this point in the history

  2. disk: refactor getVolumeSnapshotConfig 

    Split it into paramter and annotation part. Better error reporting.
And prepare for custom tags feature.
    @huww98
    huww98 committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    4c4cca6 View commit details
    Browse the repository at this point in the history

  3. disk: add tags to ECS snapshot 

    Automatically add 3 more tags to every ECS snapshot:
- ack.aliyun.com: current ACK cluster ID
- csi.alibabacloud.com/snapshot/name
- csi.alibabacloud.com/snapshot/namespace

Also allow users to add custom tags.
User should specify "snapshotTags/tagKey: tagValue" in VolumeSnapshotClass to
add tag "tagKey: tagValue".  This design allows arbitrary keys and values.
Compared with the design of disk tags, which does not allow "," in key or
value, or ":" in key.

If this design works fine, we can also implement this on disk tags.
    @huww98
    huww98 committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    d3b6fd0 View commit details
    Browse the repository at this point in the history