-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate Karpenter Disruption taints as part of preStop node evaluation #1969
Validate Karpenter Disruption taints as part of preStop node evaluation #1969
Conversation
Welcome @alexandermarston! |
Hi @alexandermarston. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thank you for this @alexandermarston /ok-to-test |
/test |
@alexandermarston: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
Code Coverage Diff
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thank you for the fix and extra unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! @alexandermarston
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Bug Fix
What is this PR about? / Why do we need it?
Fix for #1955
Karpenter introduced a breaking change in kubernetes-sigs/karpenter#508 which means it now uses the
karpenter.sh/disrupting
taint instead of thenode.kubernetes.io/unschedulable
taint when deprovisioning nodes, which means the preStop code will not run.This PR adds another check for the new Karpenter taint, instead of only looking for
node.kubernetes.io/unschedulable
.What testing is done?