-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: replace node.kubernetes.io/unschedulable with a Karpenter-specific taint #508
Conversation
Adding the blocked label so we can first vet if changing this taint right now is what we want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Pull Request Test Coverage Report for Build 6500758663
💛 - Coveralls |
Fixes #N/A
Description
Design Doc: #585
Karpenter will now use the
karpenter.sh/disrupting
taint instead ofnode.kubernetes.io/unschedulable
taint when deprovisioning nodes. Karpenter only adds this taint once it has begun spinning up replacement nodes for deprovisioning actions, and subsequently deleting the candidate node.node.kubernetes.io/unschedulable
taint or tolerate all keys: a*
toleration. If users want to ensure their daemonsets and other pods that had this toleration are not evicted as part of termination, they'll need to add this toleration to their pods.stateNode.MarkedForDeletion
variable. Karpenter can now rely on the existence of thekarpenter.sh/disrupting
taint to know when a node has been marked for deletion.How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.