-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifying Tags On Existing Volume #2082
Modifying Tags On Existing Volume #2082
Conversation
|
Welcome @mdzraf! |
Hi @mdzraf. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Code Coverage Diff
|
93827b4
to
e10693c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rough initial review, did not review the tests yet and is not super thorough. Will do a more thorough and comprehensive review later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly lgtm, a few comments and a bunch of nitpicks
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! Left a few non-blocking comments. Thanks!
examples/kubernetes/modify-volume/manifests/volumeattributesclass.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, other than
- Docs updates
- Cleanup extra files in
examples/kubernetes/modify-volume/manifests/
and fix the main example - Squash commits
- Rebase to fix
govulncheck
issue (I'll cut a PR to fix later today)
/retest |
7a5b1f2
to
957d509
Compare
957d509
to
4e7abf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review: 2 final comments, otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm, needs squash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label tide/merge-method-squash
/lgtm
aded793
to
6572609
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
New Feature
What is this PR about? / Why do we need it?
This feature allows for EBS CSI Driver customers to Add, Modify, and Delete tags of existing volumes via the official CSI
ControllerModifyVolume
RPC through aVolumeAttributesClass
.What testing is done?
Besides running existing unit and e2e tests, this feature was tested manually by doing the following:
make cluster/create
Notes:
This PR has a few extra VolumeAttributeClass documents that will be removed before merging, they are currently there because the unit tests and e2e tests for this feature are still being worked on (this is why there is some commented out code in the testing files) as well as to ensure that I can test any changes made after initial reviews.