-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change coalescer InputType from comparable
to any
#2083
Change coalescer InputType from comparable
to any
#2083
Conversation
Signed-off-by: Connor Catlett <conncatl@amazon.com>
Code Coverage DiffThis PR does not change the code coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a gotcha. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest is a flake |
Is this a bug fix or adding new feature?
Bug fix (internal facing, not customer facing)
What is this PR about? / Why do we need it?
InputType
in the coalescer shouldn't becomparable
as we don't use it as a key anywhere. Requiring it to becomparable
breaks coalescing with types that are not comparable such as maps, slices, etc. (for example see PR #2082 where it had to be added as a pointer instead of a map directly).What testing is done?
CI