Add Tags Configurations In dynamically Provisioning Access Points

[joannazhou888]

Is your feature request related to a problem? Please describe.
When using dynamic provisioning, the access point created only has the tag efs.csi.aws.com/cluster = true.
Describe the solution you'd like in detail
A clear and concise description of what you want to happen.

We would like to be able to config tags in PVC

  spec:
    accessModes:
      - ReadWriteMany
    resources:
      requests:
        storage: xx
    storageClassName: xxx
    volumeMode: Filesystem
    tags:
       - service_name : my_service
       - team: infra
       - environment: development
       ... 

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
#700

Additional context
Add any other context or screenshots about the feature request here.

[omerap12]

Maybe I can help with that :)

[omerap12]

/assign

[omerap12]

Hey @joannazhou888 ,
Kubernetes doesn't natively support a "tags" field for PVCs. instead I can make a PR to support tags for the storage-class instead. So your yaml file would looks like that:

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: efs-sc
provisioner: efs.csi.aws.com
parameters:
  provisioningMode: efs-ap
  fileSystemId: xxxxx
  directoryPerms: "700"
  pvctags: "service_name=my_service,team=infra,environment=development"

output:

What do you think?

[joannazhou888]

Hey @joannazhou888 , Kubernetes doesn't natively support a "tags" field for PVCs. instead I can make a PR to support tags for the storage-class instead. So your yaml file would looks like that:

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: efs-sc
provisioner: efs.csi.aws.com
parameters:
  provisioningMode: efs-ap
  fileSystemId: xxxxx
  directoryPerms: "700"
  pvctags: "service_name=my_service,team=infra,environment=development"

output:

What do you think?

@omerap12 Thanks! It looks good to me.

[omerap12]

Hey @joannazhou888 , Kubernetes doesn't natively support a "tags" field for PVCs. instead I can make a PR to support tags for the storage-class instead. So your yaml file would looks like that:

kind: StorageClass

apiVersion: storage.k8s.io/v1

metadata:

name: efs-sc

provisioner: efs.csi.aws.com

parameters:

provisioningMode: efs-ap

fileSystemId: xxxxx

directoryPerms: "700"

pvctags: "service_name=my_service,team=infra,environment=development"

output:

What do you think?

@omerap12 Thanks! It looks good to me.

Cool. Just need to merge the PR now