-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ability to Set Tags on StorageClass, Expand Range of Characters Supported in Tags #700
Add Ability to Set Tags on StorageClass, Expand Range of Characters Supported in Tags #700
Conversation
Hi @jonathanrainer. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eff42f5
to
4e8a46f
Compare
I have End-To-End tested this myself in an EKS cluster. Installed the driver with the following helm overrides
Then created a StorageClass to facilitate dynamic provisioning like so:
Created a PVC in the cluster to kickoff dynamic provisioning and it created an Access Point with the following tags: Then tweaked the Chart Overrides:
And the StorageClass to show the overriding behaviour:
And then got the following tags in AWS: So very happy to say that this works exactly as expected, you can pass tags with spaces and colons through the |
c2518dc
to
d286c25
Compare
d286c25
to
509d084
Compare
Before fixing the conflicts, ebs storageclass can auto add the tags like this: would efs storageclass allow it as well like this? |
509d084
to
5e030ef
Compare
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
5e030ef
to
789eefa
Compare
/remove-lifecycle rotten |
@Ashley-wenyizha Could we get an ok to test here as well? |
789eefa
to
e87c644
Compare
e87c644
to
f7539f3
Compare
f7539f3
to
d0f6f2f
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jonathanrainer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is this a bug fix or adding new feature?
This allows users to set tags on the StorageClass so they can have more granular tagging for their accessPoints should they desire, this addresses the feature requested in #692. In doing so the parsing of tags has been expanded to include characters like ':' and ' ' and so addresses #613 as well. It doesn't go quite as far as the issue suggests (i.e. aligning with the EBS driver on a standard) but it allows tags to have ':' and ' ' in them with a modicum of effort on the part of the user. That being said if we did decide in future we wanted to align and both use "=" and the key/value separator and "," as the tag separator because they're pulled out into constants that would not be very difficult.
What is this PR about? / Why do we need it?
This PR allows users to specify tags on StorageClasses and further, where tags could be specified previously, they can now include spaces, and colons as well as all the other special characters dictated by the AWS standard: https://docs.aws.amazon.com/general/latest/gr/aws_tagging.html and https://docs.aws.amazon.com/efs/latest/ug/manage-fs-tags.html
What testing is done?
I have added extra Unit tests to cover this behaviour. If it needs extra E2E tests adding please let me know
fixes #613