Helm: No support for tags with spaces

[rehevkor5]

/kind bug

What happened?

Similar to #533 , if you provide a "controller.tags" value to the Helm chart which has values that contain spaces, you will get an error in the controller's "efs-plugin" container like:

driver.go:134] Failed to parse input tag string: Application:foo Brand:Value With Spaces LaunchedBy:terraform-api

What you expected to happen?

The tag value eg. Brand:Value With Spaces should be interpreted as having the value "Value With Spaces" and no error should be logged.

How to reproduce it (as minimally and precisely as possible)?

Install the driver by using the Helm chart and providing a tag value with spaces in it. For example, in your values.yaml:

controller:
  # Add additional tags to access points
  tags:
    mytag: Value With Spaces

Anything else we need to know?:

It seems like the CSI driver for EBS has a solution for this which works a little better. See https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/charts/aws-ebs-csi-driver/templates/_helpers.tpl it appears to use commas to separate the pairs, and = to separate the key/value. For example <key1>=<value1>,<key2>=<value2>. It appears to be parsed here https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/25edc9779a6bf8608902908473d3868e05b6efb8/cmd/options/controller_options.go#L41 though I'm not very familiar with Go so I don't really see how that's happening, it looks like it's somewhere in https://github.com/spf13/pflag Edit: actually, it looks like it's in https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/25edc9779a6bf8608902908473d3868e05b6efb8/vendor/k8s.io/component-base/cli/flag/map_string_string.go#L65 although it's not clear to me how one would escape an = character in the value, which could also be annoying.

It would certainly make more sense if both of AWS' two CSI drivers followed the same config formatting/parsing approach for parameters that they both share, such as "extra tags".

Environment

• Kubernetes version (use kubectl version): 1.18
• Driver version: 2.2.1

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.