-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templatizing priotityClassName, hostNetwork, and additionalLabels in node-daemonset.yaml #1281
Templatizing priotityClassName, hostNetwork, and additionalLabels in node-daemonset.yaml #1281
Conversation
Welcome @RadOctocode! |
Hi @RadOctocode. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
62687fe
to
92ce5c9
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some new value usages that need corresponding settings in the values.yaml, and some of the changes in the storageclass.yaml template don't seem to make sense.
92ce5c9
to
7f8681a
Compare
7f8681a
to
1b1e662
Compare
1b1e662
to
5872af0
Compare
/retest |
5872af0
to
d823132
Compare
hostNetwork: false | ||
priorityClassName: system-cluster-critical |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these two default values reflect the current values?
hostNetwork: true
priorityClassName: system-node-critical
d823132
to
84cf7bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
84cf7bc
to
c96e4d8
Compare
c96e4d8
to
1b966c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG2M
/assign seanzatzdev-amazon |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevarr, r5sec5cyl, RadOctocode, seanzatzdev-amazon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/approved |
Setting We are going to open a PR to revert that piece of the change. |
Is this a bug fix or adding new feature?
This is adding some new features to the aws-efs-csi-driver helm charts
What is this PR about? / Why do we need it?
The PR is about adding changes to the aes-efs-csi-driver helm chart.
node-daemonset.yaml
What testing is done?
yes