Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Templatizing priotityClassName, hostNetwork, and additionalLabels in node-daemonset.yaml" #1288

Conversation

seanzatzdev-amazon
Copy link
Contributor

@seanzatzdev-amazon seanzatzdev-amazon commented Mar 20, 2024

Reverts #1281

Setting hostNetwork=False on the Node Daemonset will cause mounts to hang at upgrade time. See this Github issue:
#1270.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seanzatzdev-amazon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2024
@aaroniscode
Copy link

@seanzatzdev-amazon I believe the issue referenced is only about changing hostNetwork from true to false or vice-versa. Creating a brand new install using hostNetwork: false should be fine. The original PR doesn't change the default so I'm not sure it creates an issue?

@levinedaniel
Copy link

Echoing @aaroniscode, we are actively using aws-efs-csi-driver with hostnet set to false. We have seen the break when switching, but upon a clean install and actively upgrading using just hostnet=false we have been operating fully functionally.

@seanzatzdev-amazon
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@seanzatzdev-amazon: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mskanth972
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit bdb6b56 into kubernetes-sigs:master Mar 21, 2024
8 checks passed
@Adityashar
Copy link

Hi @seanzatzdev-amazon

We faced an incident due to this change of hostNetwork: true post the upgrade to aws-efs-csi-driver-v3.0.6 helm chart.
Could we please revert this field back to a configurable field so that the users have an option to manually choose between enabling or disabling this option?

hostNetwork: {{ .Values.node.hostNetwork }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants