-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Templatizing priotityClassName, hostNetwork, and additionalLabels in node-daemonset.yaml" #1288
Revert "Templatizing priotityClassName, hostNetwork, and additionalLabels in node-daemonset.yaml" #1288
Conversation
…bels in node-daemonset.yaml"
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: seanzatzdev-amazon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@seanzatzdev-amazon I believe the issue referenced is only about changing |
Echoing @aaroniscode, we are actively using aws-efs-csi-driver with hostnet set to false. We have seen the break when switching, but upon a clean install and actively upgrading using just hostnet=false we have been operating fully functionally. |
/lgtm |
@seanzatzdev-amazon: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
We faced an incident due to this change of hostNetwork: {{ .Values.node.hostNetwork }} |
Reverts #1281
Setting hostNetwork=False on the Node Daemonset will cause mounts to hang at upgrade time. See this Github issue:
#1270.