-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up deploy manifest for 1.14 #51
Conversation
a99b668
to
86d76f8
Compare
volumes: | ||
- name: socket-dir | ||
emptyDir: {} | ||
attachRequired: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you added skip-attach to the driver, could you add this to What is this PR about? / Why do we need it?
of the PR description as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, updated description to mention skip attach explicitly
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Because of skip attach relies on CSIDriver object, we need to highlight that this is backward incompatible change for 0.1 release (which is compatible with 1.13) |
Is this a bug fix or adding new feature?
bug fix+feature
What is this PR about? / Why do we need it?
What testing is done?
The static_provisioning example works correctly on a 1.14/1.15 cluster.