Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deploy manifest for 1.14 #75

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jul 24, 2019

Is this a bug fix or adding new feature? new for 1.14

What is this PR about? / Why do we need it?'

What testing is done? I built the driver with CSI v1.1.0 changes, pointed the new manifest, and tried the dynamic provisioning example. Worked.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 24, 2019
@wongma7
Copy link
Contributor Author

wongma7 commented Jul 24, 2019

This PR is roughly equivalent to kubernetes-sigs/aws-efs-csi-driver#51 + kubernetes-sigs/aws-efs-csi-driver#61 + kubernetes-sigs/aws-efs-csi-driver#62 from the EFS driver.

deploy/kubernetes/manifest.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/manifest.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/manifest.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/manifest.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/manifest.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/manifest.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/manifest.yaml Outdated Show resolved Hide resolved
@wongma7 wongma7 force-pushed the manifest branch 2 times, most recently from c9ce2ec to a16600a Compare August 13, 2019 22:05
@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 13, 2019
@leakingtapan
Copy link
Contributor

Unit testare failed:

# github.com/kubernetes-sigs/aws-fsx-csi-driver/pkg/driver [github.com/kubernetes-sigs/aws-fsx-csi-driver/pkg/driver.test]

pkg/driver/node_test.go:97:6: unknown field 'VolumeAttributes' in struct literal of type csi.NodePublishVolumeRequest

pkg/driver/node_test.go:130:6: unknown field 'VolumeAttributes' in struct literal of type csi.NodePublishVolumeRequest

FAIL	github.com/kubernetes-sigs/aws-fsx-csi-driver/pkg/driver [build failed]

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2019
@wongma7
Copy link
Contributor Author

wongma7 commented Aug 13, 2019

I just rebased, I guess it is a travis issue same as in EFS repo.

@leakingtapan
Copy link
Contributor

Seems some breaking change not caught from last merge: https://github.com/kubernetes-sigs/aws-fsx-csi-driver/blob/master/pkg/driver/node_test.go#L97

@leakingtapan
Copy link
Contributor

leakingtapan commented Aug 13, 2019

Found the issue, it's because of the flock mount option merge, which I did 😢

@wongma7
Copy link
Contributor Author

wongma7 commented Aug 13, 2019

ooh. Fixed. Well I messed up the rebase on CSI 1.1.0 PR in the first place so don't be too hard on yourself :p

@wongma7
Copy link
Contributor Author

wongma7 commented Aug 13, 2019

Now failing on goveralls

@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leakingtapan
Copy link
Contributor

merge manually due to coverall outage

@leakingtapan leakingtapan merged commit d4b4ce9 into kubernetes-sigs:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
3 participants