-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up deploy manifest for 1.14 #75
Conversation
This PR is roughly equivalent to kubernetes-sigs/aws-efs-csi-driver#51 + kubernetes-sigs/aws-efs-csi-driver#61 + kubernetes-sigs/aws-efs-csi-driver#62 from the EFS driver. |
c9ce2ec
to
a16600a
Compare
/lgtm |
Unit testare failed:
|
I just rebased, I guess it is a travis issue same as in EFS repo. |
Seems some breaking change not caught from last merge: https://github.com/kubernetes-sigs/aws-fsx-csi-driver/blob/master/pkg/driver/node_test.go#L97 |
Found the issue, it's because of the flock mount option merge, which I did 😢 |
ooh. Fixed. Well I messed up the rebase on CSI 1.1.0 PR in the first place so don't be too hard on yourself :p |
Now failing on goveralls |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
merge manually due to coverall outage |
Is this a bug fix or adding new feature? new for 1.14
What is this PR about? / Why do we need it?'
What testing is done? I built the driver with CSI v1.1.0 changes, pointed the new manifest, and tried the dynamic provisioning example. Worked.