-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Volume resizing/creation timeout scale with volume size #383
base: master
Are you sure you want to change the base?
Make Volume resizing/creation timeout scale with volume size #383
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @jonded94! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jonded94 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @jonded94. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
475003c
to
fff75ce
Compare
Is this a bug fix or adding new feature?
Bug fix
What is this PR about? / Why do we need it?
Hopefully solves Issue: #382
Increases volume creation/resizing timeout by introducing an additional linear factor for waiting longer on larger volumes.
This was done based on datapoints that @jon-rei gathered in this comment. I made a crude linear regression onto these datapoints:
The resulting formula for timeout would be (
T
timeout [s],v
volume size in GiB):T(v) = 454 + 2.18 * 10^(-3)*v
So round about 7.5 min statically and for every GiB, we'd have to wait ~2ms additionally. I used 10 min statically and 5ms for every GiB to be on the safer side.
What testing is done?
None unfortunately, I don't have an easy way of testing this.