Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Volume creation timeout configurable #384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make Volume creation timeout configurable #384

wants to merge 1 commit into from

Conversation

jonded94
Copy link

@jonded94 jonded94 commented Jul 4, 2024

Is this a bug fix or adding new feature?

Bug fix

What is this PR about? / Why do we need it?

Hopefully solves Issue: #382

Made volume creation timeout configurable by introducing a new Volume parameter "pollTimeout". This is a timeout in seconds that will be used on creation of the volume.

Found no way easily right now to make a poll timeout during resizing of the volume configurable.

What testing is done?

None unfortunately, I don't have an easy way of testing this.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jonded94
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 4, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @jonded94. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 4, 2024
@jonded94
Copy link
Author

jonded94 commented Jul 4, 2024

This is an alternative way to the PR #383. I personally don't care about a certain approach, it's just that currently, this driver unfortunately blocks us from creating large (>~60-70TiB) volumes and would like to solve that as soon as possible 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobwolfaws jacobwolfaws Awaiting requested review from jacobwolfaws

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonded94 @k8s-ci-robot