Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use envtest binaries from controller-tools repo #255

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Jun 11, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates setup-envtest to a commit on main that fetches envtest binaries from the GitHub release on the controller-tools repo. This is to move away from using GCP resource buckets.

Which issue(s) this PR fixes:
Fixes #250
See also:

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2024
@mboersma
Copy link
Contributor Author

/retest

  [FAILED] Unexpected error:
      <*fmt.wrapError | 0xc00056a600>: 
      unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in $PATH

?

@Jont828
Copy link
Contributor

Jont828 commented Jun 17, 2024

/retest

@Jont828
Copy link
Contributor

Jont828 commented Jun 17, 2024

@mboersma Is there some kind of breaking change here/is this a version bump?

@mboersma
Copy link
Contributor Author

Is there some kind of breaking change here?

Apparently so, although it was a smooth update for CAPZ. I'll take a look.

@mboersma
Copy link
Contributor Author

I think the CI failure will be fixed by kubernetes/test-infra#32803.

@mboersma
Copy link
Contributor Author

/retest

1 similar comment
@mboersma
Copy link
Contributor Author

/retest

@mboersma
Copy link
Contributor Author

@Jont828 it's passing now after changing the test-infra job not to pin the kubebuilder envtest version.

@Jont828
Copy link
Contributor

Jont828 commented Jun 25, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jont828, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cd356b5 into kubernetes-sigs:main Jun 25, 2024
12 checks passed
@mboersma mboersma deleted the bump-envtest branch June 25, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Should use a recent version of setup-envtest
3 participants