Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from google.com gcp project kubebuilder #2647

Open
spiffxp opened this issue Aug 31, 2021 · 21 comments · Fixed by #6690
Open

Migrate away from google.com gcp project kubebuilder #2647

spiffxp opened this issue Aug 31, 2021 · 21 comments · Fixed by #6690
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.

Comments

@spiffxp
Copy link
Member

spiffxp commented Aug 31, 2021

Part of umbrella issue to migrate away from google.com gcp projects: #1469

We didn't notice this because it doesn't show up anywhere in kubernetes/test-infra, but apparently kubebuilder uses a google-internal project (ref: #1469 (comment))

We need help from someone from the subproject who has access to scope out what exactly is used and determine how best to migrate, e.g.

  • maybe this can be satisfied by a k8s-staging-kubebuilder project?
  • maybe the staging project needs some special-case functionality enabled?
  • eg.

/wg k8s-infra
/sig api-machinery
/priority important-soon
/milestone v1.23

/assign @leilajal
I'm assigning to you to help with scoping out how the internal project is used and what needs to be moved over. Feel free to reassign to someone who is more familiar with kubebuilder's release process

@k8s-ci-robot k8s-ci-robot added wg/k8s-infra sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 31, 2021
@spiffxp spiffxp added this to Needs Triage in sig-k8s-infra via automation Aug 31, 2021
@spiffxp spiffxp moved this from Needs Triage to Backlog (infra to migrate) in sig-k8s-infra Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. and removed wg/k8s-infra labels Sep 29, 2021
@ameukam
Copy link
Member

ameukam commented Dec 6, 2021

/milestone clear
/help wanted

@k8s-ci-robot k8s-ci-robot removed this from the v1.23 milestone Dec 6, 2021
@leilajal
Copy link

leilajal commented Dec 6, 2021

/cc @kevindelgado

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2022
@ameukam
Copy link
Member

ameukam commented Mar 7, 2022

/remove-lifecycle stale
/lifecycle frozen
/remove-priority
/priority blacklog

@k8s-ci-robot
Copy link
Contributor

@ameukam: The label(s) priority/blacklog cannot be applied, because the repository doesn't have them.

In response to this:

/remove-lifecycle stale
/lifecycle frozen
/remove-priority
/priority blacklog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 7, 2022
@ameukam
Copy link
Member

ameukam commented Mar 7, 2022

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Mar 7, 2022
@ameukam ameukam removed the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 7, 2022
@camilamacedo86
Copy link

camilamacedo86 commented Dec 28, 2022

Hi folks,

Following is what kubebuilder and controller-runtime use from google cloud currently:

So, if it needs to be changed, we need to align and see how that should be changed, etc. Please, feel free to reach out to us via slack (channel kubebuilder, please feel free to ping me and @varshaprasad96 ). Note that all projects consume both, so no longer having those available would be a breaking change that impacts everybody.

The name of the project in the Google Cloud is kubebuilder

By the way, we need help accessing the Google Cloud because I had access to keep those maintained, but the email used for it no longer exists, and I am unable to reach out @kevindelgado, who helped us to change the email.

c/c @rpkatz

@kevindelgado
Copy link

So sorry for the delay while I was on paternity leave.

I just granted @camilamacedo86 the same access she had before for the project and her new email. For future reference, my managers @fedebongio and @leilajal also have ownership of the kubebuilder GCP project, in case any one of us can't be reached.

@camilamacedo86
Copy link

camilamacedo86 commented Sep 1, 2023

I wanted to document the most recent status:

From the current outlook, it seems unlikely that we will be able to avoid using GCP, unless there's a proposal to change the aforementioned binaries.

More info: kubernetes-sigs/kubebuilder#3230

@camilamacedo86
Copy link

Just an update here:

We revisited this issue and identified two specific needs for continuing to use Google Cloud, as detailed in these discussions: GitHub issue #2647 comment and Slack message.

We attempted to proceed with migrating the kube-rbac-proxy image as per this link: Google Cloud Registry link. However, we encountered a hurdle due to the project not being under Kubernetes-SIG. We're actively working on resolving this.

@sbueringer
Copy link
Member

We would look into what we can do about the binaries for envtest from the controller-runtime / controller-tools side.
I think it makes sense to move them over in some way to controller-runtime / controller-tools where setup-envtest already is.

@camilamacedo86
Copy link

It's crucial to emphasize that, should we find ourselves in a position to generate or promote artifacts elsewhere, it still really important we keep GCP for a long period running and promoting the artifcts that were generated in the past so that we do not broke the projects and give a good grace of time for projects be able to change.

In the case of the kube-rbac-proxy if we stop to promote it in the current location it will be very critical and will broke a lot of projects in production that are using it.

@camilamacedo86
Copy link

/re-open

@camilamacedo86
Copy link

/open

@sbueringer
Copy link
Member

/reopen

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

It looks to me like so far:

  • we have plans to sort out the binaries
  • we are phasing out the kube-rbac-proxy image

Are there any other container images that should be considered? I see many other in gcr.io/kubebuilder ...

@camilamacedo86
Copy link

camilamacedo86 commented May 14, 2024

Hi @BenTheElder,

You are right. For the Kubebuilder project itself, those are still in used (kube-rbac-proxy and env-test binaries) and we have a plan. Beyond that, the majority of what we have there is from older versions (so should be fined and seems no longer used for a long time).

However, I took another look in the GCP and found that we are using the project to generate the image gcr.io/kubebuilder/pr-verifier:$TAG_NAME. This image, generated by the project https://github.com/kubernetes-sigs/kubebuilder-release-tools, is used in the CI to verify PR emojis for release notes. I think @vincepri and @sbueringer are who has been taking care of https://github.com/kubernetes-sigs/kubebuilder-release-tools.

So, we need a plan as well for this image since it will no longer be available after March 18, 2025.

@sbueringer
Copy link
Member

sbueringer commented May 15, 2024

"taking care" is relative :) (I'm not even reviewer there 😂) But good point, didn't think about this one. I think there is no reason why it couldn't use the regular image promotion

@camilamacedo86
Copy link

Hi @sbueringer,

I think the plan with would use the shared e2e infra and the regular image promotion too. +1

@sbueringer
Copy link
Member

Quick update on the setup-envtest / envtest binary situation.

PR merged to retrieve the envtest binaries from controller-tools releases: kubernetes-sigs/controller-runtime#2811
Also cherry-pick to CR release-0.18: kubernetes-sigs/controller-runtime#2837

This means:

  • setup-envtest@release-0.18 will retrieve the binaries from GCS per default, but allows to download from controller-tools releases (I didn't want to change the default behavior on a release branch / patch release)
  • setup-envtest@main/latest/ upcoming 0.19 (release ~ in August) will download from controller-tools releases per default, while still allowing from the GCS bucket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.
Projects
Status: Reporting, Audit & Logging
sig-k8s-infra
  
Needs Triage
Development

Successfully merging a pull request may close this issue.

9 participants