[release-0.18] ✨ setup-envtest: download binaries from controller-tools releases #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
alvaroaleman
approved these changes
May 22, 2024
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: cbfa1044ce60839d128f02efc5b0e4ef57116b70
|
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
renovate bot
added a commit
to anza-labs/lke-operator
that referenced
this pull request
May 24, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `v0.18.2` -> `v0.18.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)</summary> ### [`v0.18.3`](https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.3) [Compare Source](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.18.2...v0.18.3) #### What's Changed - ✨ setup-envtest: download binaries from controller-tools releases by [@​sbueringer](https://github.com/sbueringer) in [kubernetes-sigs/controller-runtime#2837 - 🌱 Bump k8s.io/\* to v0.30.1 by [@​sbueringer](https://github.com/sbueringer) in [kubernetes-sigs/controller-runtime#2840 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.2...v0.18.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/anza-labs/lke-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImFyZWEvZGVwZW5kZW5jeSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
@sbueringer could we backport this further back into older release branches? We import setup-envtest as a pkg under Thanks! |
1 task
|
@damdo sounds good |
|
/cherry-pick release-0.17 |
|
@sbueringer: #2837 failed to apply on top of branch "release-0.17": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@damdo can you open cherry-pick PRs? |
|
Yes. Opened release-0.17, if happy with the approach I'll open others #2843 |
|
Sounds good |
hiddenmarten
added a commit
to aenix-io/etcd-operator
that referenced
this pull request
Jun 1, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [docker/login-action](https://github.com/docker/login-action) | action | minor | `v3.1.0` -> `v3.2.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) | require | minor | `v2.17.3` -> `v2.19.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) | require | patch | `v3.5.13` -> `v3.5.14` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [golangci/golangci-lint](https://github.com/golangci/golangci-lint) | | minor | `v1.58.1` -> `v1.59.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [helm/helm](https://github.com/helm/helm) | | patch | `v3.15.0` -> `v3.15.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [hugo-extended](https://github.com/jakejarvis/hugo-extended) | devDependencies | patch | [`0.126.1` -> `0.126.2`](https://renovatebot.com/diffs/npm/hugo-extended/0.126.1/0.126.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [kubernetes/kubernetes](https://github.com/kubernetes/kubernetes) | | patch | `v1.30.0` -> `v1.30.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | require | patch | `v0.18.2` -> `v0.18.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>docker/login-action (docker/login-action)</summary> ### [`v3.2.0`](https://github.com/docker/login-action/releases/tag/v3.2.0) [Compare Source](https://github.com/docker/login-action/compare/v3.1.0...v3.2.0) - Improve missing username/password by [@​Frankkkkk](https://github.com/Frankkkkk) in [docker/login-action#706 - Bump [@​docker/actions-toolkit](https://github.com/docker/actions-toolkit) from 0.18.0 to 0.24.0 in [docker/login-action#715 [docker/login-action#721 - Bump aws-sdk-dependencies to 3.583.0 in [docker/login-action#720 - Bump undici from 5.28.3 to 5.28.4 in [docker/login-action#694 **Full Changelog**: docker/login-action@v3.1.0...v3.2.0 </details> <details> <summary>onsi/ginkgo (github.com/onsi/ginkgo/v2)</summary> ### [`v2.19.0`](https://github.com/onsi/ginkgo/releases/tag/v2.19.0) [Compare Source](https://github.com/onsi/ginkgo/compare/v2.18.0...v2.19.0) #### 2.19.0 ##### Features [Label Sets](https://onsi.github.io/ginkgo/#label-sets) allow for more expressive and flexible label filtering. ### [`v2.18.0`](https://github.com/onsi/ginkgo/releases/tag/v2.18.0) [Compare Source](https://github.com/onsi/ginkgo/compare/v2.17.3...v2.18.0) #### 2.18.0 ##### Features - Add --slience-skips and --force-newlines \[[`f010b65`](https://github.com/onsi/ginkgo/commit/f010b65)] - fail when no tests were run and --fail-on-empty was set \[[`d80eebe`](https://github.com/onsi/ginkgo/commit/d80eebe)] ##### Fixes - Fix table entry context edge case \[[`42013d6`](https://github.com/onsi/ginkgo/commit/42013d6)] ##### Maintenance - Bump golang.org/x/tools from 0.20.0 to 0.21.0 ([#​1406](https://github.com/onsi/ginkgo/issues/1406)) \[[`fcf1fd7`](https://github.com/onsi/ginkgo/commit/fcf1fd7)] - Bump github.com/onsi/gomega from 1.33.0 to 1.33.1 ([#​1399](https://github.com/onsi/ginkgo/issues/1399)) \[[`8bb14fd`](https://github.com/onsi/ginkgo/commit/8bb14fd)] - Bump golang.org/x/net from 0.24.0 to 0.25.0 ([#​1407](https://github.com/onsi/ginkgo/issues/1407)) \[[`04bfad7`](https://github.com/onsi/ginkgo/commit/04bfad7)] </details> <details> <summary>etcd-io/etcd (go.etcd.io/etcd/client/v3)</summary> ### [`v3.5.14`](https://github.com/etcd-io/etcd/releases/tag/v3.5.14) [Compare Source](https://github.com/etcd-io/etcd/compare/v3.5.13...v3.5.14) Please check out [CHANGELOG](https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md) for a full list of changes. And make sure to read [upgrade guide](https://github.com/etcd-io/website/blob/main/content/en/docs/v3.5/upgrades/upgrade\_3\_5.md) before upgrading etcd (there may be breaking changes). For installation guides, please check out [play.etcd.io](http://play.etcd.io) and [operating etcd](https://github.com/etcd-io/etcd/tree/master/Documentation#operating-etcd-clusters). Latest support status for common architectures and operating systems can be found at [supported platforms](https://github.com/etcd-io/website/blob/main/content/en/docs/v3.5/op-guide/supported-platform.md). ###### Linux ```bash ETCD_VER=v3.5.14 ##### choose either URL GOOGLE_URL=https://storage.googleapis.com/etcd GITHUB_URL=https://github.com/etcd-io/etcd/releases/download DOWNLOAD_URL=${GOOGLE_URL} rm -f /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz rm -rf /tmp/etcd-download-test && mkdir -p /tmp/etcd-download-test curl -L ${DOWNLOAD_URL}/${ETCD_VER}/etcd-${ETCD_VER}-linux-amd64.tar.gz -o /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz tar xzvf /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz -C /tmp/etcd-download-test --strip-components=1 rm -f /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz /tmp/etcd-download-test/etcd --version /tmp/etcd-download-test/etcdctl version /tmp/etcd-download-test/etcdutl version ``` ```bash ##### start a local etcd server /tmp/etcd-download-test/etcd ##### write,read to etcd /tmp/etcd-download-test/etcdctl --endpoints=localhost:2379 put foo bar /tmp/etcd-download-test/etcdctl --endpoints=localhost:2379 get foo ``` ###### macOS (Darwin) ```bash ETCD_VER=v3.5.14 ##### choose either URL GOOGLE_URL=https://storage.googleapis.com/etcd GITHUB_URL=https://github.com/etcd-io/etcd/releases/download DOWNLOAD_URL=${GOOGLE_URL} rm -f /tmp/etcd-${ETCD_VER}-darwin-amd64.zip rm -rf /tmp/etcd-download-test && mkdir -p /tmp/etcd-download-test curl -L ${DOWNLOAD_URL}/${ETCD_VER}/etcd-${ETCD_VER}-darwin-amd64.zip -o /tmp/etcd-${ETCD_VER}-darwin-amd64.zip unzip /tmp/etcd-${ETCD_VER}-darwin-amd64.zip -d /tmp && rm -f /tmp/etcd-${ETCD_VER}-darwin-amd64.zip mv /tmp/etcd-${ETCD_VER}-darwin-amd64/* /tmp/etcd-download-test && rm -rf mv /tmp/etcd-${ETCD_VER}-darwin-amd64 /tmp/etcd-download-test/etcd --version /tmp/etcd-download-test/etcdctl version /tmp/etcd-download-test/etcdutl version ``` ###### Docker etcd uses [`gcr.io/etcd-development/etcd`](https://gcr.io/etcd-development/etcd) as a primary container registry, and [`quay.io/coreos/etcd`](https://quay.io/coreos/etcd) as secondary. ```bash rm -rf /tmp/etcd-data.tmp && mkdir -p /tmp/etcd-data.tmp && \ docker rmi gcr.io/etcd-development/etcd:v3.5.14 || true && \ docker run \ -p 2379:2379 \ -p 2380:2380 \ --mount type=bind,source=/tmp/etcd-data.tmp,destination=/etcd-data \ --name etcd-gcr-v3.5.14 \ gcr.io/etcd-development/etcd:v3.5.14 \ /usr/local/bin/etcd \ --name s1 \ --data-dir /etcd-data \ --listen-client-urls http://0.0.0.0:2379 \ --advertise-client-urls http://0.0.0.0:2379 \ --listen-peer-urls http://0.0.0.0:2380 \ --initial-advertise-peer-urls http://0.0.0.0:2380 \ --initial-cluster s1=http://0.0.0.0:2380 \ --initial-cluster-token tkn \ --initial-cluster-state new \ --log-level info \ --logger zap \ --log-outputs stderr docker exec etcd-gcr-v3.5.14 /usr/local/bin/etcd --version docker exec etcd-gcr-v3.5.14 /usr/local/bin/etcdctl version docker exec etcd-gcr-v3.5.14 /usr/local/bin/etcdutl version docker exec etcd-gcr-v3.5.14 /usr/local/bin/etcdctl endpoint health docker exec etcd-gcr-v3.5.14 /usr/local/bin/etcdctl put foo bar docker exec etcd-gcr-v3.5.14 /usr/local/bin/etcdctl get foo ``` </details> <details> <summary>golangci/golangci-lint (golangci/golangci-lint)</summary> ### [`v1.59.0`](https://github.com/golangci/golangci-lint/compare/v1.58.2...v1.59.0) [Compare Source](https://github.com/golangci/golangci-lint/compare/v1.58.2...v1.59.0) ### [`v1.58.2`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1582) [Compare Source](https://github.com/golangci/golangci-lint/compare/v1.58.1...v1.58.2) 1. Updated linters - `canonicalheader`: from 1.0.6 to 1.1.1 - `gosec`: from 2.19.0 to 2.20.0 - `musttag`: from 0.12.1 to 0.12.2 - `nilnil`: from 0.1.8 to 0.1.9 2. Documentation - Improve integrations and install pages </details> <details> <summary>helm/helm (helm/helm)</summary> ### [`v3.15.1`](https://github.com/helm/helm/releases/tag/v3.15.1): Helm v3.15.1 [Compare Source](https://github.com/helm/helm/compare/v3.15.0...v3.15.1) Helm v3.15.1 is a patch release. The Helm application source is the same as 3.15.0. The 3.15.0 builds stated the wrong version when running `helm version`. Instead of the release number it had the release candidate version which pointed to the same revision of the source. The community keeps growing, and we'd love to see you there! - Join the discussion in [Kubernetes Slack](https://kubernetes.slack.com): - for questions and just to hang out - for discussing PRs, code, and bugs - Hang out at the Public Developer Call: Thursday, 9:30 Pacific via [Zoom](https://zoom.us/j/696660622) - Test, debug, and contribute charts: [ArtifactHub/packages](https://artifacthub.io/packages/search?kind=0) #### Installation and Upgrading Download Helm v3.15.1. The common platform binaries are here: - [MacOS amd64](https://get.helm.sh/helm-v3.15.1-darwin-amd64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.15.1-darwin-amd64.tar.gz.sha256sum) / 5fdc60e090d183113f9fa0ae9dd9d12f0c1462b9ded286370f84e340f84bd676) - [MacOS arm64](https://get.helm.sh/helm-v3.15.1-darwin-arm64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.15.1-darwin-arm64.tar.gz.sha256sum) / 4b04ede5ab9bb226c9b198c94ce12818f0b0e302193defd66970b45fc341f6e7) - [Linux amd64](https://get.helm.sh/helm-v3.15.1-linux-amd64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.15.1-linux-amd64.tar.gz.sha256sum) / 7b20e7791c04ea71e7fe0cbe11f1a8be4a55a692898b57d9db28f3b0c1d52f11) - [Linux arm](https://get.helm.sh/helm-v3.15.1-linux-arm.tar.gz) ([checksum](https://get.helm.sh/helm-v3.15.1-linux-arm.tar.gz.sha256sum) / fa7a8b472c8f311ac618a231218511efeafad306781d11ad68976e0461074b0e) - [Linux arm64](https://get.helm.sh/helm-v3.15.1-linux-arm64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.15.1-linux-arm64.tar.gz.sha256sum) / b4c5519b18f01dd2441f5e09497913dc1da1a1eec209033ae792a8d45b9e0e86) - [Linux i386](https://get.helm.sh/helm-v3.15.1-linux-386.tar.gz) ([checksum](https://get.helm.sh/helm-v3.15.1-linux-386.tar.gz.sha256sum) / 4f8cb966bac96a186f0790a7c4528dd0278664f82fba3643aa4b37f98cf9e76b) - [Linux ppc64le](https://get.helm.sh/helm-v3.15.1-linux-ppc64le.tar.gz) ([checksum](https://get.helm.sh/helm-v3.15.1-linux-ppc64le.tar.gz.sha256sum) / 0bfe2ff8b29c1f26b0484261c0fe0d041188b2e1aa5da8e461e44083bbf655a3) - [Linux s390x](https://get.helm.sh/helm-v3.15.1-linux-s390x.tar.gz) ([checksum](https://get.helm.sh/helm-v3.15.1-linux-s390x.tar.gz.sha256sum) / 4a5314689787332d010ae782a6c00804fb83a53238f7ff7c9837c3f797ff1473) - [Linux riscv64](https://get.helm.sh/helm-v3.15.1-linux-riscv64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.15.1-linux-riscv64.tar.gz.sha256sum) / 1c49f1213c68649842c81e1806c518661aa2e466aa1c6bf1d0ac3710f554a563) - [Windows amd64](https://get.helm.sh/helm-v3.15.1-windows-amd64.zip) ([checksum](https://get.helm.sh/helm-v3.15.1-windows-amd64.zip.sha256sum) / 8ebe6d353f0fbc7e51861a676ba1c14af9efb3443ae2c78eb91946a756b93a9a) This release was signed with ` 672C 657B E06B 4B30 969C 4A57 4614 49C2 5E36 B98E ` and can be found at [@​mattfarina](https://github.com/mattfarina) [keybase account](https://keybase.io/mattfarina). Please use the attached signatures for verifying this release using `gpg`. The [Quickstart Guide](https://helm.sh/docs/intro/quickstart/) will get you going from there. For **upgrade instructions** or detailed installation notes, check the [install guide](https://helm.sh/docs/intro/install/). You can also use a [script to install](https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3) on any system with `bash`. #### What's Next - 3.15.2 is the next patch release and will be on June 12, 2024. - 3.16.0 is the next feature release and will be on September 11, 2024. #### Changelog - Fixing build issue where wrong version is used [`e211f2a`](https://github.com/helm/helm/commit/e211f2aa62992bd72586b395de50979e31231829) (Matt Farina) </details> <details> <summary>jakejarvis/hugo-extended (hugo-extended)</summary> ### [`v0.126.2`](https://github.com/jakejarvis/hugo-extended/compare/v0.126.1...v0.126.2) [Compare Source](https://github.com/jakejarvis/hugo-extended/compare/v0.126.1...v0.126.2) </details> <details> <summary>kubernetes/kubernetes (kubernetes/kubernetes)</summary> ### [`v1.30.1`](https://github.com/kubernetes/kubernetes/releases/tag/v1.30.1): Kubernetes v1.30.1 [Compare Source](https://github.com/kubernetes/kubernetes/compare/v1.30.0...v1.30.1) See [kubernetes-announce@](https://groups.google.com/forum/#!forum/kubernetes-announce). Additional binary downloads are linked in the [CHANGELOG](https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.30.md). See [the CHANGELOG](https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.30.md) for more details. </details> <details> <summary>kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)</summary> ### [`v0.18.3`](https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.3) [Compare Source](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.18.2...v0.18.3) #### What's Changed - ✨ setup-envtest: download binaries from controller-tools releases by [@​sbueringer](https://github.com/sbueringer) in [kubernetes-sigs/controller-runtime#2837 - 🌱 Bump k8s.io/\* to v0.30.1 by [@​sbueringer](https://github.com/sbueringer) in [kubernetes-sigs/controller-runtime#2840 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.2...v0.18.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * 6" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/aenix-io/etcd-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsib2stdG8tdGVzdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Hidden Marten <hiddenmarten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of #2811
Notable difference: