Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add controller-tools staging bucket & group #6670

Closed
wants to merge 1 commit into from
Closed

Add controller-tools staging bucket & group #6670

wants to merge 1 commit into from

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 8, 2024
@sbueringer
Copy link
Member Author

/hold
for mails

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2024
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Apr 8, 2024
@sbueringer
Add controller-tools staging bucket & group
db4b093 
Signed-off-by: Stefan Büringer buringerst@vmware.com
vincepri
vincepri approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/assign @dims

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alvaroaleman, sbueringer, vincepri
Once this PR has been reviewed and has the lgtm label, please ask for approval from dims. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member Author

/assign @dims

Not sure who should be assigned here

@vincepri
Copy link
Member

vincepri commented Apr 8, 2024

xref #2647

@vincepri
Copy link
Member

vincepri commented Apr 8, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2024
@vincepri
Copy link
Member

vincepri commented Apr 8, 2024

/assign @BenTheElder
as well

@ameukam
Copy link
Member

ameukam commented Apr 16, 2024

Note that the bucket created in a staging project has 90 days retention policy. Not sure if that meets your needs (I still unclearly on what we need to do this)

@sbueringer
Copy link
Member Author

/hold

To clarify what our options are (discussion ongoing in https://kubernetes.slack.com/archives/CCK68P2Q2/p1713279196825609?thread_ts=1713174342.482079&cid=CCK68P2Q2)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2024
@sbueringer
Copy link
Member Author

Closing for now. We'll try GitHub release attachments

@sbueringer
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

Assignees

@dims dims

@BenTheElder BenTheElder

@vincepri vincepri

@alvaroaleman alvaroaleman

Labels
area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sbueringer @k8s-ci-robot @vincepri @ameukam @alvaroaleman @dims @BenTheElder