Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add liveness and readiness probes #1402

Closed
ncdc opened this issue Dec 6, 2019 · 4 comments · Fixed by #1487
Closed

Add liveness and readiness probes #1402

ncdc opened this issue Dec 6, 2019 · 4 comments · Fixed by #1487
Assignees
@cpanato
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.5.0

Comments

@ncdc
Copy link
Contributor

ncdc commented Dec 6, 2019

User Story

As a developer/user/operator I would like to have liveness and readiness probes for the Cluster API manager so that I am better informed when it is operational and ready to receive requests.

Detailed Description

See user story.

Anything else you would like to add:

It would be ideal if the readiness probe could only return true once the webhook server is online and ready to receive requests. I'm not sure how feasible this is, though.

/kind feature
/milestone v0.5.0
/priority important-soon
/help

(This is a clone of kubernetes-sigs/cluster-api#1855 so we should try to be consistent with our solution.)
@k8s-ci-robot
Copy link
Contributor

@ncdc:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

User Story

As a developer/user/operator I would like to have liveness and readiness probes for the Cluster API manager so that I am better informed when it is operational and ready to receive requests.

Detailed Description

See user story.

Anything else you would like to add:

It would be ideal if the readiness probe could only return true once the webhook server is online and ready to receive requests. I'm not sure how feasible this is, though.

/kind feature
/milestone v0.5.0
/priority important-soon
/help

(This is a clone of kubernetes-sigs/cluster-api#1855 so we should try to be consistent with our solution.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v0.5.0 milestone Dec 6, 2019
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 6, 2019
@joonas
Copy link

joonas commented Dec 20, 2019

Related: kubernetes-sigs/cluster-api#1855

@cpanato
Copy link
Member

cpanato commented Jan 14, 2020

i can try this one if possible

@cpanato
Copy link
Member

cpanato commented Jan 15, 2020

/assign

@cpanato cpanato mentioned this issue Jan 16, 2020
Merged
@ncdc ncdc added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jan 17, 2020
k8s-ci-robot added a commit that referenced this issue Jan 29, 2020
@k8s-ci-robot
Merge pull request #1487 from cpanato/GH-1402
03dd538 
✨ Add liveness/readiness probes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpanato cpanato

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

✨ Add liveness/readiness probes
4 participants
@ncdc @joonas @cpanato @k8s-ci-robot