✨ Add liveness/readiness probes

[cpanato]

What this PR does / why we need it:
Add liveness and readiness probes

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1402

/kind feature
/milestone v0.5.0
/priority important-soon

[k8s-ci-robot]

@cpanato: You must be a member of the kubernetes-sigs/cluster-api-provider-aws-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Provider AWS Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

What this PR does / why we need it:
Add liveness and readiness probes

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1402

/kind feature
/milestone v0.5.0
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @cpanato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cpanato]

/assign @ncdc

[ncdc]

Thanks for this!

[ncdc]

/ok-to-test

[ncdc]

/lgtm
/assign @vincepri

[ncdc]

/hold

[ncdc]

Need to squash before we merge, but wait for Vince's review.

[vincepri]

One comment about the port

[cpanato]

@vincepri do you want to change the port to use 8080 or we can keep this one? i think in the example you post it is using that because it is a webapp application.
I was checking around and there is no standard port, at least i did not see in any place documented.

for example:

• kube-dns uses 10054
• coredns uses 8080
• kubernetes-dashboard uses 8443
• the old tiller from helm uses 44135

[vincepri]

I don't have super strong opinions, either way it should be ok, as long as we document these ports somewhere and have some sort of convention

[cpanato]

@vincepri @ncdc added a document to describe the ports used by CAPA, please let me know if that is not the right place.
PTAL

[cpanato]

@ncdc @vincepri squashed. ptal
thanks!

[vincepri]

/hold cancel
/approve
/assign @ncdc

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ncdc]

/lgtm