Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add liveness/readiness probes #2156

Merged
merged 1 commit into from
Jan 28, 2020
Merged

✨ Add liveness/readiness probes #2156

merged 1 commit into from
Jan 28, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jan 27, 2020

What this PR does / why we need it:
similar from kubernetes-sigs/cluster-api-provider-aws#1487 this adds a health endpoint for CAPI

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 27, 2020
@cpanato cpanato requested a review from ncdc January 27, 2020 14:02
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 27, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @cpanato!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @cpanato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2020
@vincepri
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2020
@cpanato
Copy link
Member Author

cpanato commented Jan 27, 2020

/test pull-cluster-api-integration

@vincepri
Copy link
Member

It seems that the example-provider-ci-amd64 isn't coming up in CI after this change

@vincepri
Copy link
Member

@cpanato We need to add the probe to https://github.com/kubernetes-sigs/cluster-api/blob/master/cmd/example-provider/main.go as well

@cpanato
Copy link
Member Author

cpanato commented Jan 27, 2020

@vincepri thanks! will do

vincepri
vincepri approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

waiting for e2e tests to pass before LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@cpanato
Copy link
Member Author

cpanato commented Jan 27, 2020

/test pull-cluster-api-test
/test pull-cluster-api-integration

now more are failing 😓

@vincepri
Copy link
Member 

cmd/example-provider/main.go:76:3: undefined: setupLog
cmd/example-provider/main.go:81:3: undefined: setupLog

seems like a build failure

@cpanato
Copy link
Member Author

cpanato commented Jan 27, 2020

my bad :(

@cpanato
Copy link
Member Author

cpanato commented Jan 27, 2020

@vincepri all green now. was my fault in the previous tests

vincepri
vincepri approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/assign @ncdc

@ncdc ncdc added this to the v0.3.0 milestone Jan 27, 2020
@ncdc
Copy link
Contributor

ncdc commented Jan 27, 2020

LGTM. Please squash!

@cpanato
Copy link
Member Author

cpanato commented Jan 28, 2020

@ncdc done! thanks for your review

@ncdc
Copy link
Contributor

ncdc commented Jan 28, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 54420c4 into kubernetes-sigs:master Jan 28, 2020
@cpanato cpanato deleted the GH-1855 branch January 29, 2020 06:56
@cpanato cpanato mentioned this pull request Jan 29, 2020
Merged
@cpanato cpanato mentioned this pull request Feb 14, 2020
Merged
This was referenced Mar 2, 2020
Merged
Merged
Closed
@cpanato cpanato mentioned this pull request Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@ncdc ncdc Awaiting requested review from ncdc

@detiber detiber Awaiting requested review from detiber

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@ncdc ncdc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Add liveness and readiness probes
4 participants
@cpanato @k8s-ci-robot @vincepri @ncdc