-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add liveness/readiness probes #2156
Conversation
Welcome @cpanato! |
Hi @cpanato. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-cluster-api-integration |
It seems that the |
@cpanato We need to add the probe to https://github.com/kubernetes-sigs/cluster-api/blob/master/cmd/example-provider/main.go as well |
@vincepri thanks! will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
waiting for e2e tests to pass before LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-test now more are failing 😓 |
seems like a build failure |
my bad :( |
@vincepri all green now. was my fault in the previous tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/assign @ncdc
LGTM. Please squash! |
@ncdc done! thanks for your review |
/lgtm |
What this PR does / why we need it:
similar from kubernetes-sigs/cluster-api-provider-aws#1487 this adds a health endpoint for CAPI
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):