✨manager/docker: add liveness/readiness probes

[cpanato]

What this PR does / why we need it:
Add liveness/readiness probes similar did here #2156

• also change a bit the code to be similar that is made in capi

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
related #1855

/cc @vincepri

[k8s-ci-robot]

Hi @cpanato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chuckha]

/ok-to-test

Is this mostly for consistency's sake?

[randomvariable]

Is this mostly for consistency's sake?

We did add this to the AWS provider, so makes sense to add elsewhere.

[chuckha]

Is this mostly for consistency's sake?

We did add this to the AWS provider, so makes sense to add elsewhere.

Yeah, it really doesn't change CAPD in any way because the only interesting health check we need is to know when the web hook servers are ready. That would clean up some retries in the framework. But this is fine to make it look more consistent.

I was wondering if this was coming from some other bug that this fixes or some behavior this corrects in addition to consistency or if consistency was the only reason for this PR.

[randomvariable]

Nevermind, i didn't realise this was just for the docker provider.

[vincepri]

/approve
/assign @chuckha

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/infrastructure/docker/OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chuckha]

/lgtm