Wait for webhook readiness and healthy #2685

geetikabatra · 2021-08-19T09:50:59Z

This change adds a ready and health check on the webhook server.

Release note:

Signed-off-by: Geetika Batra geetika.b@vmware.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

squashed commits
includes documentation
adds unit tests
adds or updates e2e tests

Release note:

Add readiness and health checks to webhook server

k8s-ci-robot · 2021-08-19T09:51:02Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-08-19T09:51:07Z

Welcome @geetikabatra!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-08-19T09:51:07Z

Hi @geetikabatra. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

randomvariable · 2021-08-19T10:12:49Z

@geetikabatra looks like you haven't signed the CNCF CLA?

/assign @sedefsavas
as the last person who was touching this.

geetikabatra · 2021-08-19T10:34:47Z

@randomvariable, I had the wrong email set in my config. If @sedefsavas wants to take it forward. I will close this PR.

sbueringer · 2021-08-19T11:23:16Z

main.go

 		setupLog.Error(err, "unable to create ready check")
 		os.Exit(1)
 	}

-	if err := mgr.AddHealthzCheck("ping", healthz.Ping); err != nil {
+	if err := mgr.AddReadyzCheck("webhook", mgr.GetWebhookServer().StartedChecker()); err != nil {


Suggested change

if err := mgr.AddReadyzCheck("webhook", mgr.GetWebhookServer().StartedChecker()); err != nil {

if err := mgr.AddHealthzCheck("webhook", mgr.GetWebhookServer().StartedChecker()); err != nil {

@sbueringer Thanks for the review. But unfortunately closing it as @sedefsavas was already working on it.

@sbueringer Updated the suggested change. Please take a look. Thanks in advance.

@geetikabatra Looks good thx. I think you have to change your commit message: #2685 (comment) (and drop the link to the issue)

randomvariable · 2021-08-19T14:51:12Z

@geetikabatra i meant @sedefsavas to look at the PR as we did previously have this and took it out and I wasn't directly involved in that decision.

geetikabatra · 2021-08-19T14:54:54Z

@randomvariable ohh okay! I will fix it as per @sbueringer 's comments.

sedefsavas · 2021-08-20T15:53:06Z

@geetikabatra We should do the same for EKS. See: #2603

geetikabatra · 2021-08-23T08:25:39Z

@sedefsavas EKS has been moved out of the experimental feature. So, the change in EKS is not necessary now, I think.
I didn't see any other instance of ping being used anywhere else in the repository. I think we are good to go here. WDYT?

sedefsavas · 2021-08-23T13:10:23Z

@sedefsavas EKS has been moved out of the experimental feature. So, the change in EKS is not necessary now, I think.
I didn't see any other instance of ping being used anywhere else in the repository. I think we are good to go here. WDYT?

Right! Forgot about it.

/ok-to-test

randomvariable · 2021-08-24T09:03:03Z

@geetikabatra
Please remove

Fixes: #2602

Release note:

from the commit message. In general, Prow will fail commit messages that do Fixes # etc...

In addition, please review the errors:

./main.go:39:2: imported and not used: "sigs.k8s.io/controller-runtime/pkg/healthz"

This change adds a ready and health check on the webhook server. Signed-off-by: Geetika Batra geetika.b@vmware.com

geetikabatra · 2021-08-24T09:46:03Z

Done!

sbueringer · 2021-08-24T10:01:26Z

Thx!
/lgtm

randomvariable · 2021-08-25T11:08:27Z

/area cleanup
/approve

k8s-ci-robot · 2021-08-25T11:08:28Z

@randomvariable: The label(s) area/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

/area cleanup
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-08-25T11:08:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [randomvariable]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 19, 2021

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-priority labels Aug 19, 2021

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2021

k8s-ci-robot requested review from dthorsen and randomvariable August 19, 2021 09:51

geetikabatra force-pushed the webhook branch from 0583b19 to 98d3a1a Compare August 19, 2021 09:56

geetikabatra changed the title ~~What this PR does / why we need it:~~ Wait for webhook readiness and healthy Aug 19, 2021

geetikabatra mentioned this pull request Aug 19, 2021

Add webhook health check #2602

Closed

geetikabatra force-pushed the webhook branch from 98d3a1a to d4a7236 Compare August 19, 2021 10:02

k8s-ci-robot assigned sedefsavas Aug 19, 2021

sbueringer reviewed Aug 19, 2021

View reviewed changes

geetikabatra closed this Aug 19, 2021

randomvariable reopened this Aug 19, 2021

geetikabatra force-pushed the webhook branch from d4a7236 to 6a8ce2f Compare August 20, 2021 11:48

k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 20, 2021

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 23, 2021

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 23, 2021

Wait for webhook readiness and healthy

c6dfb7a

This change adds a ready and health check on the webhook server. Signed-off-by: Geetika Batra geetika.b@vmware.com

geetikabatra force-pushed the webhook branch from 6a8ce2f to c6dfb7a Compare August 24, 2021 09:38

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 24, 2021

k8s-ci-robot assigned sbueringer Aug 24, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2021

k8s-ci-robot merged commit a4f7010 into kubernetes-sigs:main Aug 25, 2021

k8s-ci-robot added this to the v0.7.0 milestone Aug 25, 2021

geetikabatra mentioned this pull request Jul 4, 2022

REQUEST: New membership for @geetikabatra kubernetes/org#3538

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wait for webhook readiness and healthy #2685

Wait for webhook readiness and healthy #2685

geetikabatra commented Aug 19, 2021 •

edited by randomvariable

Loading

k8s-ci-robot commented Aug 19, 2021

k8s-ci-robot commented Aug 19, 2021

k8s-ci-robot commented Aug 19, 2021

randomvariable commented Aug 19, 2021

geetikabatra commented Aug 19, 2021

sbueringer Aug 19, 2021

geetikabatra Aug 19, 2021

geetikabatra Aug 20, 2021

sbueringer Aug 20, 2021

geetikabatra Aug 24, 2021

randomvariable commented Aug 19, 2021

geetikabatra commented Aug 19, 2021

sedefsavas commented Aug 20, 2021

geetikabatra commented Aug 23, 2021 •

edited

Loading

sedefsavas commented Aug 23, 2021

randomvariable commented Aug 24, 2021

geetikabatra commented Aug 24, 2021

sbueringer commented Aug 24, 2021

randomvariable commented Aug 25, 2021

k8s-ci-robot commented Aug 25, 2021

k8s-ci-robot commented Aug 25, 2021

	if err := mgr.AddReadyzCheck("webhook", mgr.GetWebhookServer().StartedChecker()); err != nil {
	if err := mgr.AddHealthzCheck("webhook", mgr.GetWebhookServer().StartedChecker()); err != nil {

Wait for webhook readiness and healthy #2685

Wait for webhook readiness and healthy #2685

Conversation

geetikabatra commented Aug 19, 2021 • edited by randomvariable Loading

k8s-ci-robot commented Aug 19, 2021

k8s-ci-robot commented Aug 19, 2021

k8s-ci-robot commented Aug 19, 2021

randomvariable commented Aug 19, 2021

geetikabatra commented Aug 19, 2021

sbueringer Aug 19, 2021

Choose a reason for hiding this comment

geetikabatra Aug 19, 2021

Choose a reason for hiding this comment

geetikabatra Aug 20, 2021

Choose a reason for hiding this comment

sbueringer Aug 20, 2021

Choose a reason for hiding this comment

geetikabatra Aug 24, 2021

Choose a reason for hiding this comment

randomvariable commented Aug 19, 2021

geetikabatra commented Aug 19, 2021

sedefsavas commented Aug 20, 2021

geetikabatra commented Aug 23, 2021 • edited Loading

sedefsavas commented Aug 23, 2021

randomvariable commented Aug 24, 2021

geetikabatra commented Aug 24, 2021

sbueringer commented Aug 24, 2021

randomvariable commented Aug 25, 2021

k8s-ci-robot commented Aug 25, 2021

k8s-ci-robot commented Aug 25, 2021

geetikabatra commented Aug 19, 2021 •

edited by randomvariable

Loading

geetikabatra commented Aug 23, 2021 •

edited

Loading