Add webhook health check

[sbueringer]

/kind feature

Describe the solution you'd like
It would be nice if the controller health checks would use the readiness of the webhook server (instead of the no-op Ping).

For reference, the implementation in cluster-api: kubernetes-sigs/cluster-api#4989

Anything else you would like to add:
This requires at least controller-runtime v0.9.3.

Environment:

• Cluster-api-provider-aws version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[sbueringer]

Webhook health check was removed in #2629 due to a bug which lead to tls handshake errors. Fix PR has been merged in controller-runtime, but we have to wait until the next controller-runtime release (0.9.6) to integrate it.

xref:

• Slack discussion: https://kubernetes.slack.com/archives/CD6U2V71N/p1627643594012600
• bugfix PR: 🐛 0.9: fix webhook health check tls handshake timeout errors controller-runtime#1616

/reopen

[k8s-ci-robot]

@sbueringer: Reopened this issue.

In response to this:

Webhook health check was removed due to a bug found which lead to tls handshake errors in #2629. Fix PR has been merged in controller-runtime, but we have to wait until the next controller-runtime release to integrate it.

xref:

• Slack discussion: https://kubernetes.slack.com/archives/CD6U2V71N/p1627643594012600
• bugfix PR: 🐛 0.9: fix webhook health check tls handshake timeout errors controller-runtime#1616

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

fyi controller-runtime v0.9.6 has been released with a fix. So we should be good to go (I also verified it via the e2e tests of the cluster-api repo).

[geetikabatra]

@sbueringer Here is the PR that fixes this #2685

[sbueringer]

Has been fixed in #2685

/close

[k8s-ci-robot]

@sbueringer: Closing this issue.

In response to this:

Has been fixed in #2685

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.