✨ add webhook readiness and health check #4989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/cc @vincepri |
k8s-ci-robot
added
the
size/S
|
/lgtm great to see that we can do this now cc @devigned |
k8s-ci-robot
added
the
lgtm
|
Oh, cool! +1 |
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-add-webhook-healthcheck
branch
from
9a4efa2
to
bc720b4
Compare
k8s-ci-robot
removed
the
lgtm
|
Had to rebase |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Great! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Jul 26, 2021
2 tasks
kashifest
added a commit
to Nordix/cluster-api-provider-metal3
that referenced
this pull request
Aug 31, 2021
Currently the readiness of our controller deployments does not include the webhook server. I.e., the deployment is already ready even when the webhooks are not up. The current PR will help that the wait for readiness will also include the webhook server. This is crucial because otherwise there's a chance that clusterctl immediately fails when we try to deploy resources. Follows: kubernetes-sigs/cluster-api#4989
kashifest
added a commit
to Nordix/metal3-ipam
that referenced
this pull request
Aug 31, 2021
Currently the readiness of our controller deployments does not include the webhook server. I.e., the deployment is already ready even when the webhooks are not up. The current PR will help that the wait for readiness will also include the webhook server. This is crucial because otherwise there's a chance that clusterctl immediately fails when we try to deploy resources. Follows: kubernetes-sigs/cluster-api#4989
kashifest
added a commit
to Nordix/metal3-ipam
that referenced
this pull request
Sep 1, 2021
Currently the readiness of our controller deployments does not include the webhook server. I.e., the deployment is already ready even when the webhooks are not up. The current PR will help that the wait for readiness will also include the webhook server. This is crucial because otherwise there's a chance that clusterctl immediately fails when we try to deploy resources. Follows: kubernetes-sigs/cluster-api#4989
kashifest
added a commit
to Nordix/metal3-ipam
that referenced
this pull request
Sep 1, 2021
Currently the readiness of our controller deployments does not include the webhook server. I.e., the deployment is already ready even when the webhooks are not up. The current PR will help that the wait for readiness will also include the webhook server. This is crucial because otherwise there's a chance that clusterctl immediately fails when we try to deploy resources. Follows: kubernetes-sigs/cluster-api#4989
fmuyassarov
pushed a commit
to Nordix/cluster-api-provider-metal3
that referenced
this pull request
Sep 2, 2021
Currently the readiness of our controller deployments does not include the webhook server. I.e., the deployment is already ready even when the webhooks are not up. The current PR will help that the wait for readiness will also include the webhook server. This is crucial because otherwise there's a chance that clusterctl immediately fails when we try to deploy resources. Follows: kubernetes-sigs/cluster-api#4989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Currently the readiness of our controller deployments does not include the webhook server. I.e., the deployment is already ready even when the webhooks are not up.
So when we implement a wait for deployments ready in #4934 the current PR will help that the wait for readiness will also include the webhook server. This is crucial because otherwise there's a chance that clusterctl immediately fails when we try to deploy resources.
Note: This controller-runtime health check is only available since v0.9.3 (kubernetes-sigs/controller-runtime#1598)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Improves the accuracy of the wait we'll implement in #4934 for #4474
Follow-up: