Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ clusterctl init: wait for deployments to be ready #4934

Merged
merged 1 commit into from
Aug 12, 2021
Merged

⚠️ clusterctl init: wait for deployments to be ready #4934

merged 1 commit into from
Aug 12, 2021

Conversation

ykakarap
Copy link
Contributor

@ykakarap ykakarap commented Jul 13, 2021 •
edited
Loading

What this PR does / why we need it:
clusterctl init should wait for the cluster to be 'ready' before exiting.
This includes:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4474

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 13, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 13, 2021
fabriziopandini
fabriziopandini reviewed Jul 20, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ykakarap thanks for getting started this effort!

Given that this could be considered a behaviour/breaking change, IMO we should start making waiting optional adding a --wait (-w) flag which should be false by default.
WDYT?

cmd/clusterctl/client/cluster/installer.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/installer.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/installer.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/installer.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/installer.go Outdated Show resolved Hide resolved
@sbueringer sbueringer mentioned this pull request Jul 21, 2021
Merged
1 task
@ykakarap ykakarap force-pushed the init-wait-ready branch 2 times, most recently from f57f271 to d4fc049 Compare July 28, 2021 00:21
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2021
@ykakarap ykakarap changed the title ✨ [WIP] clusterctl init: wait for deployments to be ready ✨ clusterctl init: wait for deployments to be ready Jul 28, 2021
@ykakarap
Copy link
Contributor Author

/assign @fabriziopandini

@sbueringer sbueringer mentioned this pull request Jul 28, 2021
Closed
sbueringer
sbueringer reviewed Jul 28, 2021
View reviewed changes
cmd/clusterctl/client/cluster/installer.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/installer.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/installer.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/installer.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/init.go Show resolved Hide resolved
cmd/clusterctl/cmd/init.go Outdated Show resolved Hide resolved
cmd/clusterctl/internal/util/objs.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/installer.go Show resolved Hide resolved
fabriziopandini
fabriziopandini reviewed Jul 28, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, lgtm apart a couple of nits

cmd/clusterctl/client/cluster/installer.go Show resolved Hide resolved
cmd/clusterctl/client/cluster/installer.go Outdated Show resolved Hide resolved
cmd/clusterctl/cmd/init.go Outdated Show resolved Hide resolved
cmd/clusterctl/internal/util/objs.go Outdated Show resolved Hide resolved
cmd/clusterctl/internal/util/objs.go Outdated Show resolved Hide resolved
@ykakarap ykakarap changed the title ✨ clusterctl init: wait for deployments to be ready ⚠️ clusterctl init: wait for deployments to be ready Aug 5, 2021
@ykakarap ykakarap force-pushed the init-wait-ready branch 2 times, most recently from 403ab32 to 20a0457 Compare August 12, 2021 03:22
@k8s-ci-robot
Copy link
Contributor

@ykakarap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-main bff7e6b link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2021
vincepri
vincepri approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0188b29 into kubernetes-sigs:master Aug 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlipovetsky dlipovetsky dlipovetsky left review comments

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@pshail pshail pshail left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@vincepri vincepri vincepri approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

clusterctl doesn't wait for deployments to be available
8 participants
@ykakarap @k8s-ci-robot @sbueringer @vincepri @dlipovetsky @fabriziopandini @pshail @CecileRobertMichon