-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webhook health check #1221
Comments
There was an error found in the healthcheck. The fix PR is already merged in controller-runtime, but we should wait until the next controller-runtime version is released (0.9.6) with adding it to CAPV. xref: |
fyi controller-runtime v0.9.6 has been released with a fix. So we should be good to go (I also verified it via the e2e tests of the cluster-api repo). |
/close |
@srm09: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature
Describe the solution you'd like
It would be nice if the controller health checks would use the readiness of the webhook server (instead of the no-op Ping).
For reference, the implementation in cluster-api: kubernetes-sigs/cluster-api#4989
Anything else you would like to add:
This requires at least controller-runtime v0.9.3.
Environment:
kubectl version
):/etc/os-release
):The text was updated successfully, but these errors were encountered: