Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook health check #1221

Closed
sbueringer opened this issue Jul 26, 2021 · 4 comments
Closed

Add webhook health check #1221

sbueringer opened this issue Jul 26, 2021 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sbueringer
Copy link
Member

/kind feature

Describe the solution you'd like
It would be nice if the controller health checks would use the readiness of the webhook server (instead of the no-op Ping).

For reference, the implementation in cluster-api: kubernetes-sigs/cluster-api#4989

Anything else you would like to add:
This requires at least controller-runtime v0.9.3.

Environment:

  • Cluster-api-provider-vsphere version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 26, 2021
@sbueringer
Copy link
Member Author

There was an error found in the healthcheck. The fix PR is already merged in controller-runtime, but we should wait until the next controller-runtime version is released (0.9.6) with adding it to CAPV.

xref:

@sbueringer
Copy link
Member Author

fyi controller-runtime v0.9.6 has been released with a fix. So we should be good to go (I also verified it via the e2e tests of the cluster-api repo).

@srm09
Copy link
Contributor

srm09 commented Nov 3, 2021

/close

@k8s-ci-robot
Copy link
Contributor

@srm09: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants