-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Kubernetes to v1.24.0 and fix AWSMachinePool minsize #3468
Conversation
@sedefsavas: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
go.mod
Outdated
golang.org/x/text v0.3.7 | ||
gopkg.in/yaml.v2 v2.4.0 | ||
k8s.io/api v0.23.5 | ||
k8s.io/api v0.24.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those k8s.io/* versions all have to stay the same (or at least stay on v0.23.x)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! finally reverted those properly.
c75e375
to
32f46ea
Compare
/test ? |
@sedefsavas: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e-blocking |
KUBERNETES_VERSION: "v1.23.3" | ||
KUBERNETES_VERSION_UPGRADE_TO: "v1.23.3" | ||
KUBERNETES_VERSION_UPGRADE_FROM: "v1.22.4" | ||
KUBERNETES_VERSION_MANAGEMENT: "v1.24.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to keep this version on v1.23.3 for now.
The problem is that only kind v0.13 is compatible with kindest/node:v1.24.0+ and we didn't bump the kind version yet.
I think this should be okay for now given that we mostly want to verify that CAPI is able to manage v1.24 clusters vs kind being able to create v1.24 bootstrap clusters.
xref: the CI failure during kind create cluster: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/3468/pull-cluster-api-provider-aws-e2e/1525045134981337088
(cc @fabriziopandini)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest v1.1.x release we should now be able to use v1.24 as mgmt cluster. with kind
/test pull-cluster-api-provider-aws-e2e-blocking |
/test pull-cluster-api-provider-aws-e2e |
@sedefsavas any leads on this PR? |
/test pull-cluster-api-provider-aws-e2e |
Reason of the machinepool failure was e2e-config was using an old nightly image as the latest of 1.1.x capi version. |
ah that makes sense! I did wonder whether this needs updating but wasn't sure. Thanks for fixing! |
/test pull-cluster-api-provider-aws-e2e |
@sedefsavas: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-cluster-api-provider-aws-e2e |
/assign @richardcase EKS tests passed in the previous run. |
/hold cancel |
This all looks ok to me /lgtm |
/approve Ups there is a pull-cluster-api-provider-aws-build-release-1-5 job running, there must be a bug in the release-1.5 jobs. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sedefsavas: #3468 failed to apply on top of branch "release-1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Bumping cluster-api version to v1.1.5 and Kubernetes version we use in e2e tests to v1.24.0.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3242
Fixes #3600
Special notes for your reviewer:
Checklist: