Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bump kind to v1.14.0 and cluster-api to v1.1.4 #3506

Closed
wants to merge 1 commit into from

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Jun 6, 2022

What type of PR is this?
/area release

What this PR does / why we need it:
Bump the versions of:

  1. Kind version to v1.14.0
  2. Cluster-api version to v1.1.4

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 6, 2022
@k8s-ci-robot
Copy link
Contributor

@Ankitasw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ankitasw Ankitasw changed the title Bump controller-runtime, kind, and cluster-api versions [WIP] Bump controller-runtime, kind, and cluster-api versions Jun 6, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign enxebre after the PR has been reviewed.
You can assign the PR to them by writing /assign @enxebre in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 6, 2022
@Ankitasw Ankitasw changed the title [WIP] Bump controller-runtime, kind, and cluster-api versions [WIP] Bump controller-runtime, kind, golang and cluster-api versions Jun 6, 2022
@Ankitasw Ankitasw changed the title [WIP] Bump controller-runtime, kind, golang and cluster-api versions [WIP] Bump controller-runtime, kind, and cluster-api versions Jun 6, 2022
@Ankitasw Ankitasw changed the title [WIP] Bump controller-runtime, kind, and cluster-api versions [WIP] Bump kind and cluster-api versions Jun 6, 2022
@Ankitasw Ankitasw changed the title [WIP] Bump kind and cluster-api versions [WIP] Bump kind to v1.14.0 and cluster-api to v1.1.4 Jun 6, 2022
@sedefsavas
Copy link
Contributor

For bumping dependencies to 1.24.0, we might need to bump controller runtime at the same time.
See relevant slack thread here.

I think you can bump to CAPI v1.1.3, but you can’t bump to Kubernetes v1.24 libs at the same time

Also, this PR is relevant:
kubernetes-sigs/cluster-api#6467

Testing v1.24 without bumping the dependencies here:
#3468

@k8s-ci-robot
Copy link
Contributor

@Ankitasw: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2022
@Ankitasw
Copy link
Member Author

Ankitasw commented Jun 7, 2022

For bumping dependencies to 1.24.0, we might need to bump controller runtime at the same time.
See relevant slack thread here.

I think you can bump to CAPI v1.1.3, but you can’t bump to Kubernetes v1.24 libs at the same time

Also, this PR is relevant:
kubernetes-sigs/cluster-api#6467

Testing v1.24 without bumping the dependencies here:
#3468

Then shall we merge all these bumps to the same PR which you are testing for 1.24 without dependencies?

@k8s-ci-robot
Copy link
Contributor

@Ankitasw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-build c6a4986 link true /test pull-cluster-api-provider-aws-build
pull-cluster-api-provider-aws-test c6a4986 link true /test pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-verify c6a4986 link true /test pull-cluster-api-provider-aws-verify
pull-cluster-api-provider-aws-build-release-1-5 c6a4986 link true /test pull-cluster-api-provider-aws-build-release-1-5

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Ankitasw
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@Ankitasw: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants