🐛 Update filenames for released binaries #5055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change only updates the binary naming template to match previous releases. There is still an issue of building the same binary twice under two different names. Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
kranurag7
approved these changes
Jul 16, 2024
|
Thanks /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlipovetsky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only updates the binary naming template to match previous
releases. There is still an issue of building the same binary twice
under two different names.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Releases prior to implementing goreleaser used the
clusterawsadm-{{ .Os }}-{{ .Platform}}format. See v2.4.0 as an example of this format.This does not address the issue of building the same binary twice. We still need to address whether we would like to use
clusterctl-awsorclusterawsadmgoing forward.I will create an issue to track this.See #5056 for tackling the double binary problem.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: