Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong urls for clusterawsadm file for both Linux and MacOs in the quick start #10169

Closed
salehsedghpour opened this issue Feb 19, 2024 · 9 comments · Fixed by #10170
Closed

Wrong urls for clusterawsadm file for both Linux and MacOs in the quick start #10169

salehsedghpour opened this issue Feb 19, 2024 · 9 comments · Fixed by #10170
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@salehsedghpour
Copy link
Contributor

What steps did you take and what happened?

For Linux I followed the instruction:

curl -L https://github.com/kubernetes-sigs/cluster-api/releases/download/v2.3.1/clusterawsadm-linux-amd64 -o clusterawsadm

For MacOS:

# Intel
curl -L https://github.com/kubernetes-sigs/cluster-api/releases/download/v2.3.1/clusterawsadm-darwin-amd64 -o clusterawsadm

#ARM
curl -L https://github.com/kubernetes-sigs/cluster-api/releases/download/v2.3.1/clusterawsadm-darwin-arm64 -o clusterawsadm

In all cases, when I investigated the content of downloaded file, I only saw Not Found

$ cat clusterawsadm 
Not Found

What did you expect to happen?

I expected to download the the actual CLI and just noticed that the URL is wrong and I needed to use the following url in all commands:

# Linux
https://github.com/kubernetes-sigs/cluster-api-provider-aws/releases/download/v2.3.1/clusterawsadm-linux-amd64

# MacOS Intel
https://github.com/kubernetes-sigs/cluster-api-provider-aws/releases/download/v2.3.1/clusterawsadm-darwin-amd64

# MacOS ARM
https://github.com/kubernetes-sigs/cluster-api-provider-aws/releases/download/v2.3.1/clusterawsadm-darwin-arm64

Cluster API version

v1.6 (v1beta1)

Kubernetes version

1.29

Anything else you would like to add?

No response

Label(s) to be applied

/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

CAPI contributors will take a look as soon as possible, apply one of the triage/* labels and provide further guidance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member

I think its getting worked on this at #9870 but seems to be stale currently.

@salehsedghpour
Copy link
Contributor Author

I was wondering if that PR is only targeting Windows environments.

@chrischdi
Copy link
Member

Ah I think you're right. We just identified the url is wrong also for windows there 👍

@sbueringer
Copy link
Member

Yeah looks like CAPA changed the name of the binary with v2.5.0. If that was an intended change the CAPI book should be updated accordingly (we should probably confirm)

@sbueringer
Copy link
Member

@nrb @vincepri @dlipovetsky Looking for confirmation that the new binary name was intentional, then we would update the docs in core CAPI.

@dlipovetsky
Copy link
Contributor

Thanks for the ping. Following up.

@nrb
Copy link
Contributor

nrb commented Jul 15, 2024

This has been fixed for the affected releases. I have also made a PR to fix it going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants