Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix broken release links for clusterawsadm in Quick starts #10170

Merged

Conversation

salehsedghpour
Copy link
Contributor

@salehsedghpour salehsedghpour commented Feb 19, 2024

What this PR does / why we need it:
In quick start documentation we have some incorrect urls for downloading clusterawsadm. This PR mainly fixes the urls for Linux and MacOS operating systems. As #9870 is fixing it for Windows.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10169
Fixes #9795

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2024
@richardcase
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: de6664ad901e4c450c7410764171b2e8052088c7

@salehsedghpour
Copy link
Contributor Author

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation and removed do-not-merge/needs-area PR is missing an area label labels Feb 19, 2024
@chrischdi
Copy link
Member

Could you also please fix the windows part so all are working?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@salehsedghpour
Copy link
Contributor Author

salehsedghpour commented Feb 19, 2024

@chrischdi It's now done. I updated the PR description to close both #10169 and #9795.

@chrischdi
Copy link
Member

/lgtm
/approve

Thanks for tackling this :-)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1d9272b9d5b345e4941384c3854a77fe0a557f35

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 39d2a34 into kubernetes-sigs:main Feb 19, 2024
36 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Feb 19, 2024
@salehsedghpour salehsedghpour deleted the fix-broken-release-links branch February 19, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
4 participants