-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use dl.k8s.io instead of hardcoded GCS URIs #399
Conversation
/test ls |
@cpanato: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-provider-gcp-make-conformance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Aaron
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Use dl.k8s.io instead of hardcoded GCS URIs
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The only time a kubernetes GCS bucket name should be showing up in a
hardcoded URI is if
gsutil
is being used (e.g. gsutil cp gs://foo/bar .)Otherwise, for tools like
curl
orwget
, dl.k8s.io is much nicer for usas a project, since we can transparently change where that redirects to
without having to change code everywhere
These changes will mean no changes will be necessary to accommodate a
gs://kubernetes-release
->gs://k8s-release
migration equivalent ofthe CI migration we're going through right now
These changes also address the
gs://kubernetes-release-dev
referencescurrently used by this repo (ref:
kubernetes/k8s.io#2318)
Special notes for your reviewer:
I'm not sure that a release note is required for this, but I put one in
just in case
Similar / related PRs:
TODOs:
includes documentation(n/a)adds unit tests(n/a)Release note: