Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dl.k8s.io instead of hardcoded GCS URIs #399

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 17, 2021

Use dl.k8s.io instead of hardcoded GCS URIs

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The only time a kubernetes GCS bucket name should be showing up in a
hardcoded URI is if gsutil is being used (e.g. gsutil cp gs://foo/bar .)

Otherwise, for tools like curl or wget, dl.k8s.io is much nicer for us
as a project, since we can transparently change where that redirects to
without having to change code everywhere

These changes will mean no changes will be necessary to accommodate a
gs://kubernetes-release -> gs://k8s-release migration equivalent of
the CI migration we're going through right now

These changes also address the gs://kubernetes-release-dev references
currently used by this repo (ref:
kubernetes/k8s.io#2318)

Special notes for your reviewer:

I'm not sure that a release note is required for this, but I put one in
just in case

Similar / related PRs:

TODOs:

  • squashed commits
  • includes documentation (n/a)
  • adds unit tests (n/a)

Release note:

kubernetes artifacts are pulled from https://dl.k8s.io instead of
hardcoded GCS bucket URIs (kubernetes-release, kubernetes-release-dev)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 17, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2021
@cpanato
Copy link
Member

cpanato commented Jul 18, 2021

/test ls

@k8s-ci-robot
Copy link
Contributor

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cluster-api-provider-gcp-test
  • /test pull-cluster-api-provider-gcp-build
  • /test pull-cluster-api-provider-gcp-make
  • /test pull-cluster-api-provider-gcp-e2e-test
  • /test pull-cluster-api-provider-gcp-make-conformance
  • /test pull-cluster-api-provider-gcp-capi-e2e

Use /test all to run the following jobs:

  • pull-cluster-api-provider-gcp-test
  • pull-cluster-api-provider-gcp-build
  • pull-cluster-api-provider-gcp-make
  • pull-cluster-api-provider-gcp-e2e-test

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member

cpanato commented Jul 18, 2021

/test pull-cluster-api-provider-gcp-make-conformance

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Aaron
/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 549b434 into kubernetes-sigs:main Jul 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jul 19, 2021
@spiffxp spiffxp deleted the use-dl-k8s-io branch July 19, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants