🌱 Use dl.k8s.io instead of hardcoded GCS URIs #4958
Conversation
The only time a kubernetes GCS bucket name should be showing up in a hardcoded URI is if gsutil is being used (e.g. gsutil cp gs://foo/bar .) Otherwise, for tools like curl or wget, dl.k8s.io is much nicer for us as a project, since we can transparently change where that redirects to without having to change code everywhere
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/cc @CecileRobertMichon @sbueringer @randomvariable |
|
/test pull-cluster-api-test-main |
| resolveVersion=$(curl -LsS "http://gcsweb.k8s.io/gcs/kubernetes-release-dev/ci/${version#ci/}.txt") | ||
| resolveVersion=$(curl -LsS "http://dl.k8s.io/ci/${version#ci/}.txt") |
There was a problem hiding this comment.
FYI: this might still be causing you to pickup stale builds depending on how racy/flaky the build and build-deprecated jobs are. You're getting the version marker from gs://kubernetes-release-dev, but the binaries from gs://k8s-release-dev
Using dl.k8s.io for both means you don't have to think about it
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main |
|
@spiffxp @CecileRobertMichon You probably also want to do this in CAPZ: https://github.com/kubernetes-sigs/cluster-api-provider-azure/search?q=gs%3A%2F%2F |
|
@sbueringer Thanks for pointing it out. Moving to dl.k8s.io is not as urgent this month, but I'll be tracking that work under kubernetes/k8s.io#2396 as part of v1.23. I just thought I'd take care of it while I was handling the kubernetes-release-dev / k8s-release-dev stuff here. |
What this PR does / why we need it:
Sort of a follow-on to #4420
The only time a kubernetes GCS bucket name should be showing up in a
hardcoded URI is if gsutil is being used (e.g. gsutil cp gs://foo/bar .)
Otherwise, for tools like curl or wget, dl.k8s.io is much nicer for us
as a project, since we can transparently change where that redirects to
without having to change code everywhere
These changes will mean no changes will be necessary to accommodate a
gs://kubernetes-release -> gs://k8s-release migration equivalent of the
CI migration we're going through right now
(kubernetes/k8s.io#2318)
EDIT: this also catches one last mention of
kubernetes-release-devwhich I've called out in a review comment belowWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #