IP Address Assignments and AssignedTo fields are unused response bloat

[displague]

In #354, a change in EM API include fields to add details about the IP Addresses resulted in a large increase in the response time and size for IP address list responses for large projects.

We'll want to revert this.

In CAPP, the resulting Assignments field in the IP address lists is only used in len() calls to determine if an address is in use.

cluster-api-provider-packet/controllers/packetmachine_controller.go

Lines 327 to 331 in a6d3608

	if len(controlPlaneEndpoint.Assignments) == 0 {
	a := corev1.NodeAddress{
	Type: corev1.NodeExternalIP,
	Address: controlPlaneEndpoint.Address,
	}

It appears that assignments and assignments.assigned_to includes are not necessary for this purpose. Countable href objects are returned in an assignments list without explicit includes.

We see further proof of this when comparing metal-cli commands (debug output reveals that metal-cli nor packngo are adding unsolicited include values):

$ metal ips get -o json | jq '.[].assignments|length'  | sort -n | uniq -c 
     29 0
      1 1
      2 3

$ metal ips get -o json --include assignments,assignments.assigned_to | jq '.[].assignments|length'  | sort -n | uniq -c 
     29 0
      1 1
      2 3

Originally posted by @displague in #354 (comment)