Include IP assigmenets when reconciling VIP ips

[cprivitere]

on CPEM clusters.

Signed-off-by: Chris Privitere 23177737+cprivitere@users.noreply.github.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cprivitere

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cprivitere]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[displague]

This change increased the response time and size for IP address lists fetched from the EM API. We'll want to revert this.

In CAPP, the resulting Assignments field in the IP address lists is only used in len() calls to determine if an address is in use. It appears that assignments and assignments.assigned_to includes are not necessary for this purpose. Countable href objects are returned in an assignments list without explicit includes.

We see further proof of this when comparing metal-cli commands (debug output reveals that metal-cli nor packngo are adding unsolicited include values):

$ metal ips get -o json | jq '.[].assignments|length'  | sort -n | uniq -c 
     29 0
      1 1
      2 3

$ metal ips get -o json --include assignments,assignments.assigned_to | jq '.[].assignments|length'  | sort -n | uniq -c 
     29 0
      1 1
      2 3

[displague]

IIRC, this PR was made to ensure that the assignments would continue to be included in the event that they became optional in the future. Including the Assignments and AssignedTo fields is a pattern copied from the web console.

Defensive coding.