Revert "Include IP assigmenets when reconciling VIP ips"

[displague]

What this PR does / why we need it:

This reverts commit 7429b47. (see #464)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #464

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: displague

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [displague]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ocobles]

/lgtm

It seems safe to revert it, only the length of the Assignments is being used, and it is obtained from the client without the Assignments include list options

cluster-api-provider-packet/controllers/packetmachine_controller.go

Line 327 in a6d3608

if len(controlPlaneEndpoint.Assignments) == 0 {

cluster-api-provider-packet/controllers/packetmachine_controller.go

Line 391 in a6d3608

if len(controlPlaneEndpoint.Assignments) == 0 && machineScope.IsControlPlane() {

[ocobles]

/lgtm

[k8s-ci-robot]

@ocobleseqx: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[displague]

/lgtm

[k8s-ci-robot]

@displague: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.