Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 Add support for tilt #197

Merged
merged 1 commit into from
Nov 12, 2020
Merged

🏃 Add support for tilt #197

merged 1 commit into from
Nov 12, 2020

Conversation

detiber
Copy link
Member

@detiber detiber commented Oct 28, 2020

What this PR does / why we need it:

This allows development using Tilt for this provider: https://cluster-api.sigs.k8s.io/developer/tilt.html

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Oct 28, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 28, 2020
@gianarb
Copy link
Contributor

gianarb commented Oct 29, 2020

Out of curiosity, all the 56 files changed are for tilt only? o.O

detiber
detiber commented Oct 29, 2020
View reviewed changes
tilt-provider.json
Comment on lines +1 to +9
{
"name": "packet",
"config": {
"image": "packethost/cluster-api-provider-packet",
"live_reload_deps": [
"main.go", "go.mod", "go.sum", "api", "controllers", "pkg"
]
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gianarb This is the main bit that is needed for Tilt support, however I quickly ran into issues because the Tilt utilities in the CAPI repo assume that the provider components can be built by running kustomize against the /config directory.

The rest of the changes were to facilitate running kustomize against the /config directory and align the manifest sources and generation more with other providers.

@detiber detiber mentioned this pull request Nov 9, 2020
Merged
@gianarb
Copy link
Contributor

gianarb commented Nov 12, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 33bb233 into kubernetes-sigs:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deitch deitch Awaiting requested review from deitch

@thebsdbox thebsdbox Awaiting requested review from thebsdbox

Assignees

@gianarb gianarb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@detiber @k8s-ci-robot @gianarb