-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 e2e fixes #201
🏃 e2e fixes #201
Conversation
.gitignore
Outdated
@@ -39,3 +39,6 @@ _artifacts | |||
|
|||
# Goreleaser | |||
dist | |||
|
|||
# Tilt | |||
.tiltbuild/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new line
Makefile
Outdated
.PHONY: modules | ||
modules: ## Runs go mod to ensure modules are up to date. | ||
go mod tidy | ||
cd $(TOOLS_DIR); go mod tidy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new line
tilt-provider.json
Outdated
"main.go", "go.mod", "go.sum", "api", "controllers", "pkg" | ||
] | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new line
Rebased on top of latest HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Fixes up issues with the e2e test configuration
Builds on top of #197