✨ Remove-capp-e2e-tags #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to add an env override for useragent tracking for things like this in the future. The ldflags method was causing problems. Also moving the built in client and ua formatting back to constants. Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cprivitere The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Use packet client instead of packngo.client Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
displague
reviewed
Jul 25, 2022
and clientUAFormat as vars. Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Privitere 23177737+cprivitere@users.noreply.github.com
What this PR does / why we need it:
The capp e2e testing useragent overrides via ldflags resulted in an akward situation. The few calls to equinix metal done by the e2e test code itself had the correct useragent, but the majority of calls via the manager did not, due to the CI framework pre-building the manager and thus not gettting any of the ldflag overrides from the E2E tests.
Current thinking is to add an Environment variable in the future which can add more UserAgent information. #385