Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Remove-capp-e2e-tags #384

Merged
merged 4 commits into from
Jul 26, 2022
Merged

✨ Remove-capp-e2e-tags #384

merged 4 commits into from
Jul 26, 2022

Commits on Jul 25, 2022

  1. Remove separate ldflags for capp-e2e 

    We're going to add an env override for useragent
tracking for things like this in the future. The ldflags
method was causing problems.
Also moving the built in client and ua formatting
back to constants.

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
    @cprivitere
    cprivitere committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    5a8fc7f View commit details
    Browse the repository at this point in the history

  2. Use packet.NewClient for consistency 

    Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
    @cprivitere
    cprivitere committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    1f22539 View commit details
    Browse the repository at this point in the history

  3. Clean up packngo calls. 

    Use packet client instead of packngo.client

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
    @cprivitere
    cprivitere committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    126f72c View commit details
    Browse the repository at this point in the history

  4. Go back to having the clientName 

    and clientUAFormat as vars.

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
    @cprivitere
    cprivitere committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    43e764b View commit details
    Browse the repository at this point in the history