Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in new templates #420

Merged
merged 18 commits into from
Sep 16, 2022
Merged

Fix errors in new templates #420

merged 18 commits into from
Sep 16, 2022

Conversation

cprivitere
Copy link
Member

Remove docker.io from apt-get remove line
Install containerd.io instead of containerd
Add quotes around the kubernetes pause image

Signed-off-by: Chris Privitere 23177737+cprivitere@users.noreply.github.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #419

ocobles and others added 2 commits September 8, 2022 15:33
@ocobles
Update go install script and add kustomize install script
2b02c69
@cprivitere
Remove docker.io from apt-get remove line
b2dbab8 
Install containerd.io instead of containerd
Add quotes around the kubernetes pause image

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cprivitere

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2022
@cprivitere cprivitere marked this pull request as draft September 9, 2022 19:30
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2022
@cprivitere cprivitere self-assigned this Sep 9, 2022
@cprivitere
ran make generate
0477692 
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2022
@cprivitere
Copy link
Member Author

/honk

@k8s-ci-robot
Copy link
Contributor

@cprivitere:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cprivitere
Copy link
Member Author

/joke

@k8s-ci-robot
Copy link
Contributor

@cprivitere: Why do mathematicians hate the U.S.? Because it's indivisible.

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cprivitere
Update defaults list
f29d64a 
Removed things that were required and had no defaults
Added a variable for CPEM verison

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@cprivitere
Fix environment setup
e034b22 
Move the commands to run on all control plane nodes
Remove unnecessary KUBECONFIG export to save a line

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@cprivitere
Fix kube-vip setup
41f91da 
Move the kube-vip manifest setup to after kubeadm is run,
this avoids a situation where kube-vip fights with previous
control plane nodes before they've joined the cluster.
Move the crictl/kubectl commands to run on all control plane nodes
Remove unnecessary KUBECONFIG export to save a line

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@cprivitere
Only setup kube-vip before kubeadm on first node
e585a54 
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@cprivitere
Run make generate
d5fa66a 
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2022
@cprivitere cprivitere marked this pull request as ready for review September 13, 2022 19:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2022
k8s-ci-robot and others added 10 commits September 16, 2022 07:39
@k8s-ci-robot
Merge pull request kubernetes-sigs#412 from ocobleseqx/update_go_inst…
9e1aab6 
…all_script

Update go install script and add kustomize install script
@cprivitere
Remove docker.io from apt-get remove line
9872228 
Install containerd.io instead of containerd
Add quotes around the kubernetes pause image

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@cprivitere
ran make generate
10fdaa0 
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@cprivitere
Update defaults list
edf12ba 
Removed things that were required and had no defaults
Added a variable for CPEM verison

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@cprivitere
Fix environment setup
5f8f05d 
Move the commands to run on all control plane nodes
Remove unnecessary KUBECONFIG export to save a line

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@cprivitere
Fix kube-vip setup
9a82297 
Move the kube-vip manifest setup to after kubeadm is run,
this avoids a situation where kube-vip fights with previous
control plane nodes before they've joined the cluster.
Move the crictl/kubectl commands to run on all control plane nodes
Remove unnecessary KUBECONFIG export to save a line

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@cprivitere
Only setup kube-vip before kubeadm on first node
9876764 
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@cprivitere
Run make generate
bf28d93 
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@cprivitere
Merge branch 'cprivitere/issue419' of https://github.com/cprivitere/c…
e039523 
…luster-api-provider-packet into cprivitere/issue419
@cprivitere
Add tools bin to path for e2e testing's sake
5f522c3 
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@displague
Copy link
Member

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8d2e4db into kubernetes-sigs:main Sep 16, 2022
@cprivitere cprivitere deleted the cprivitere/issue419 branch March 20, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deitch deitch Awaiting requested review from deitch

@detiber detiber Awaiting requested review from detiber

Assignees

@displague displague

@cprivitere cprivitere

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in new templates
4 participants
@cprivitere @k8s-ci-robot @displague @ocobles