Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PACKET_API_KEY fron cluster template #51

Merged
merged 1 commit into from
May 14, 2020
Merged

Remove PACKET_API_KEY fron cluster template #51

merged 1 commit into from
May 14, 2020

Conversation

deitch
Copy link
Contributor

@deitch deitch commented May 14, 2020

Does a few things:

  • inject the apiKey into the userData where needed when actually deploying a control plane machine, so it no longer needs it in the template (as it shouldn't)
  • removes the apiKey from the template
  • fixes some missing info in the Makefile that was causing it not to regenerate

@deitch deitch requested a review from gianarb May 14, 2020 09:41
@gianarb gianarb merged commit 9780a91 into v1alpha3 May 14, 2020
@gianarb gianarb deleted the inject-secret branch May 14, 2020 09:57
@deitch deitch mentioned this pull request May 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianarb gianarb gianarb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deitch @gianarb