Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing fields #52

Merged
merged 1 commit into from
May 14, 2020
Merged

add missing fields #52

merged 1 commit into from
May 14, 2020

Conversation

deitch
Copy link
Contributor

@deitch deitch commented May 14, 2020

I do not know why, but applying this without these fields causes it to fail. Since it is auto-generated, it doesn't hurt.

@deitch deitch requested a review from gianarb May 14, 2020 09:43
@gianarb
Copy link
Contributor

gianarb commented May 14, 2020

Yeah it is part of #49 as well

@deitch
Copy link
Contributor Author

deitch commented May 14, 2020

Ah, I didn't realize you had it. I stumbled across it when testing #51 and thought it just got missed.

When we get #49 in, we can close this.

@gianarb gianarb closed this May 14, 2020
@deitch
Copy link
Contributor Author

deitch commented May 14, 2020

@gianarb these were not added in #49

@deitch deitch reopened this May 14, 2020
@gianarb
Copy link
Contributor

gianarb commented May 14, 2020

o.O I dreamed about it

@gianarb gianarb merged commit 5665cb7 into v1alpha3 May 14, 2020
@deitch deitch deleted the fix-machinedeployment branch May 14, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianarb gianarb gianarb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deitch @gianarb