🌱 Sync golangci-lint configuration to core CAPI

[chrischdi]

What this PR does / why we need it:

This PR syncs the .golangci.yml configuration file with the one of core CAPI.

There are parts still commented out on purpose, to not introduce too many different changes at a single PR but to uncomment them in future PRs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Part of #2058

Additional info

Exclude-rules omitted, which are part of core CAPI:

  - linters:
      - staticcheck
    text: "SA1019: (bootstrapv1.ClusterStatus|scope.Config.Spec.UseExperimentalRetryJoin|DockerMachine.Spec.Bootstrapped|machineStatus.Bootstrapped) is deprecated"
...
  - linters:
    - staticcheck
    text: "SA1019: (clusterv1alpha3.*|clusterv1alpha4.*) is deprecated: This type will be removed in one of the next releases."
...
  - linters:
    - revive
    text: exported (method|function|type|const) (.+) should have comment or be unexported
    path: cmd/clusterctl/internal/test/providers.*.go
  - linters:
    - revive
    text: exported (method|function|type|const) (.+) should have comment or be unexported
    path: "(framework|e2e)/.*.go"
...
  - path: util/defaulting/defaulting.go
    text: should not use dot imports
...
  # hack/tools
  - linters:
    - typecheck
    text: import (".+") is a program, not an importable package
    path: ^tools\.go$

[srm09]

/retest

[chrischdi]

/retest

[srm09]

/retest

[srm09]

/retest

[srm09]

/retest

[chrischdi]

/retest

[chrischdi]

/retest

[srm09]

/retest

[sbueringer]

Thank you very much!

[chrischdi]

@sbueringer PTAL :-)

[chrischdi]

WaitingForIPAllocation

/test pull-cluster-api-provider-vsphere-e2e-main

[sbueringer]

Thank you very much!

Very good first step

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: dc8c3940d614f1c57c5dc19583b0d70773194784

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chrischdi]

/retest-required

[chrischdi]

/test pull-cluster-api-provider-vsphere-e2e-main

[sbueringer]

/retest

[chrischdi]

/test pull-cluster-api-provider-vsphere-e2e-main

[chrischdi]

/retest-required

[chrischdi]

/retest-required

[sbueringer]

/retest-required

[chrischdi]

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-e2e-main d3e363f link true /test pull-cluster-api-provider-vsphere-e2e-main
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

This one did not hit the previous error. Only a single VM waiting for kubeadm init.

/retest-required

[chrischdi]

/retest-required

[killianmuldoon]

/lgtm

[sbueringer]

/retest