-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Sync golangci-lint configuration to core CAPI #2173
🌱 Sync golangci-lint configuration to core CAPI #2173
Conversation
e36dfad
to
f0aaf31
Compare
/retest |
7 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
335674b
to
df238fe
Compare
df238fe
to
d3e363f
Compare
@sbueringer PTAL :-) |
WaitingForIPAllocation /test pull-cluster-api-provider-vsphere-e2e-main |
Thank you very much! Very good first step /lgtm |
LGTM label has been added. Git tree hash: dc8c3940d614f1c57c5dc19583b0d70773194784
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/test pull-cluster-api-provider-vsphere-e2e-main |
/retest |
/test pull-cluster-api-provider-vsphere-e2e-main |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
This one did not hit the previous error. Only a single VM waiting for kubeadm init. /retest-required |
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
What this PR does / why we need it:
This PR syncs the
.golangci.yml
configuration file with the one of core CAPI.There are parts still commented out on purpose, to not introduce too many different changes at a single PR but to uncomment them in future PRs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #2058
Additional info
Exclude-rules omitted, which are part of core CAPI: