-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit golangci-lint config #2058
Comments
/assign |
Let's tackle this in multiple steps:
EDIT: moved this list to the top / initial comment as task list. |
I was debugging my PR and found out that it doesn't print any lines and code for specific lint error. Found out here it could be fixed by Verified here https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/actions/runs/5791075333/job/15695267905?pr=2171 |
@chrischdi Let's add a final step to diff against the core CAPI file again (just to make sure we didn't miss anything that we would want to have sync) |
Update the above list and the initial MR |
I already have a PR prepared as follow-up to enable the importas configuration. |
Feel free to move the sub-task list in the issue description itself in case you think it's better (fine either way for me) |
I'll start with this one :)
|
/assign @zhanggbj |
We can assign multiple people, just pick a linter and let us know :) /help |
@sbueringer: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'll go with this one: 😊
|
/assign @MrDXY |
Hi, folks, I created another pr to track the following task. #2273
|
Hi. Just created a new PR to enable ginkgolinter; See #2282 |
Hi team, I will continue with |
Hi folks, I will proceed with enabling the configuration for |
/assign |
I will take this - remove |
Took up some parts of
in: |
I'm going to have a go at adding comments across the code under |
I ran a diff between CAPV and CAPI golanglint-ci.yaml config files and there's nothing unexpected there. There's a tiny update to formatting in the CAPI file that will make diffing slightly easier - I'll raise that one in a PR. Thanks everyone for your contributions! @chrischdi I think we should close this if your happy with it - there's some follow-ups in #2384. |
/close |
@killianmuldoon: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Let's compare the golangci-lint config with the one from core CAPI and see if we should add more linters / config etc. (also potentially in core CAPI).
Some observations:
importas
linter for at least the most important imports to get some consistencyTasks
The text was updated successfully, but these errors were encountered: