-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add args to golangci-lint to show lines number #2180
Conversation
Q: Do the PR annotations still work with this flag? Possibly related: there was some work in golangci-lint to allow multiple format: golangci/golangci-lint-action#362 (comment) (IIRC) |
Looks like it will, now it supports several output, if output doesn't contain github-action it will append automatically. The PR that fixed 362 actually is just adding |
Sounds good. Thx for looking into it. Let's give it a try |
/lgtm /assign @killianmuldoon |
LGTM label has been added. Git tree hash: e1558c9e02e18ca2bd1874749b501f3972503251
|
Will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
What this PR does / why we need it:
Right now the error doesn't show exact line that has issue.
With this fix, then the error log will be more descriptive.
Example: here https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/actions/runs/5791075333/job/15695267905?pr=2171
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes ##2058